Re: [PATCH v11 4/8] ata: libahci: allow to use multiple PHYs

2014-07-30 Thread Kishon Vijay Abraham I
On Thursday 24 July 2014 02:47 PM, Antoine Ténart wrote: > The current implementation of the libahci does not allow to use multiple > PHYs. This patch adds the support of multiple PHYs by the libahci while > keeping the old bindings valid for device tree compatibility. > > This introduce a new w

Re: [PATCH v11 4/8] ata: libahci: allow to use multiple PHYs

2014-07-29 Thread Antoine Ténart
Hi, On Mon, Jul 28, 2014 at 01:27:24PM -0400, Tejun Heo wrote: > On Mon, Jul 28, 2014 at 12:29:56PM +0200, Hans de Goede wrote: > ... > > > + if (!enabled_ports) { > > > + dev_warn(dev, "No port enabled\n"); > > > + return ERR_PTR(-ENODEV); > > > > This sho

Re: [PATCH v11 4/8] ata: libahci: allow to use multiple PHYs

2014-07-28 Thread Tejun Heo
On Mon, Jul 28, 2014 at 12:29:56PM +0200, Hans de Goede wrote: ... > > + if (!enabled_ports) { > > + dev_warn(dev, "No port enabled\n"); > > + return ERR_PTR(-ENODEV); > > This should be: > rc = -ENODEV; > go

Re: [PATCH v11 4/8] ata: libahci: allow to use multiple PHYs

2014-07-28 Thread Hans de Goede
Hi, Thanks, this version is almost perfect, unfortunately a second review has found one small issue in it, see inline comment below. On 07/24/2014 11:17 AM, Antoine Ténart wrote: > The current implementation of the libahci does not allow to use multiple > PHYs. This patch adds the support of mult