Re: [PATCH v12 04/36] remoteproc: k3-m4: Don't assert reset in detach routine

2025-05-20 Thread Hari Nagalla
On 5/20/25 00:06, Beleswar Prasad Padhi wrote: Hi Mathieu, On 19/05/25 20:07, Mathieu Poirier wrote: On Sat, May 17, 2025 at 06:53:29PM +0530, Beleswar Prasad Padhi wrote: On 5/16/2025 9:15 PM, Mathieu Poirier wrote: On Tue, May 13, 2025 at 11:14:38AM +0530, Beleswar Padhi wrote: The rproc_d

Re: [PATCH v12 04/36] remoteproc: k3-m4: Don't assert reset in detach routine

2025-05-20 Thread Martyn Welch
On 17/05/2025 14:23, Beleswar Prasad Padhi wrote: On 5/16/2025 9:15 PM, Mathieu Poirier wrote: On Tue, May 13, 2025 at 11:14:38AM +0530, Beleswar Padhi wrote: The rproc_detach() function invokes __rproc_detach() before rproc_unprepare_device(). The __rproc_detach() function sets the rproc->

Re: [PATCH v12 04/36] remoteproc: k3-m4: Don't assert reset in detach routine

2025-05-19 Thread Beleswar Prasad Padhi
Hi Mathieu, On 19/05/25 20:07, Mathieu Poirier wrote: > On Sat, May 17, 2025 at 06:53:29PM +0530, Beleswar Prasad Padhi wrote: >> On 5/16/2025 9:15 PM, Mathieu Poirier wrote: >>> On Tue, May 13, 2025 at 11:14:38AM +0530, Beleswar Padhi wrote: The rproc_detach() function invokes __rproc_detach

Re: [PATCH v12 04/36] remoteproc: k3-m4: Don't assert reset in detach routine

2025-05-19 Thread Mathieu Poirier
On Sat, May 17, 2025 at 06:53:29PM +0530, Beleswar Prasad Padhi wrote: > > On 5/16/2025 9:15 PM, Mathieu Poirier wrote: > > On Tue, May 13, 2025 at 11:14:38AM +0530, Beleswar Padhi wrote: > > > The rproc_detach() function invokes __rproc_detach() before > > > rproc_unprepare_device(). The __rproc_

Re: [PATCH v12 04/36] remoteproc: k3-m4: Don't assert reset in detach routine

2025-05-17 Thread Beleswar Prasad Padhi
On 5/16/2025 9:15 PM, Mathieu Poirier wrote: On Tue, May 13, 2025 at 11:14:38AM +0530, Beleswar Padhi wrote: The rproc_detach() function invokes __rproc_detach() before rproc_unprepare_device(). The __rproc_detach() function sets the rproc->state to "RPROC_DETACHED". However, the TI K3 M4 dri

Re: [PATCH v12 04/36] remoteproc: k3-m4: Don't assert reset in detach routine

2025-05-16 Thread Mathieu Poirier
On Tue, May 13, 2025 at 11:14:38AM +0530, Beleswar Padhi wrote: > The rproc_detach() function invokes __rproc_detach() before > rproc_unprepare_device(). The __rproc_detach() function sets the > rproc->state to "RPROC_DETACHED". > > However, the TI K3 M4 driver erroneously looks for "RPROC_ATTACHE