Re: [PATCH v12 2/3] rust: add parameter support to the `module!` macro

"Benno Lossin" writes: > On Wed Jun 11, 2025 at 12:31 PM CEST, Andreas Hindborg wrote: >> "Benno Lossin" writes: >>> On Tue May 6, 2025 at 3:02 PM CEST, Andreas Hindborg wrote: diff --git a/rust/macros/helpers.rs b/rust/macros/helpers.rs index a3ee27e29a6f..16d300ad3d3b 100644 ---

Re: [PATCH v12 2/3] rust: add parameter support to the `module!` macro

On Wed Jun 11, 2025 at 12:31 PM CEST, Andreas Hindborg wrote: > "Benno Lossin" writes: >> On Tue May 6, 2025 at 3:02 PM CEST, Andreas Hindborg wrote: >>> diff --git a/rust/macros/helpers.rs b/rust/macros/helpers.rs >>> index a3ee27e29a6f..16d300ad3d3b 100644 >>> --- a/rust/macros/helpers.rs >>> ++

Re: [PATCH v12 2/3] rust: add parameter support to the `module!` macro

"Miguel Ojeda" writes: > On Wed, Jun 11, 2025 at 2:24 PM Andreas Hindborg > wrote: >> >> So either we need to `#[allow(missing_docs)]` or just add the line back. >> What do you prefer? > > Do you mean if you remove the `concat!` too, right? Yes, all of it. > > It would need to be `expect`, b

Re: [PATCH v12 2/3] rust: add parameter support to the `module!` macro

On Wed, May 7, 2025 at 1:23 PM Benno Lossin wrote: > > > +unsafe extern "C" fn set_param( > > +val: *const kernel::ffi::c_char, > > +param: *const crate::bindings::kernel_param, > > +) -> core::ffi::c_int New instance of `core::ffi::` (and both these `c_*` should be unqualified). Cheers,

Re: [PATCH v12 2/3] rust: add parameter support to the `module!` macro

On Wed, Jun 11, 2025 at 2:24 PM Andreas Hindborg wrote: > > So either we need to `#[allow(missing_docs)]` or just add the line back. What > do you prefer? Do you mean if you remove the `concat!` too, right? It would need to be `expect`, but I think even an `expect(missing_docs)` is not really u

Re: [PATCH v12 2/3] rust: add parameter support to the `module!` macro

Andreas Hindborg writes: > "Benno Lossin" writes: > >> On Tue May 6, 2025 at 3:02 PM CEST, Andreas Hindborg wrote: >>> Add support for module parameters to the `module!` macro. Implement read >>> only support for integer types without `sysfs` support. >>> >>> Acked-by: Petr Pavlu # from modules

Re: [PATCH v12 2/3] rust: add parameter support to the `module!` macro

"Benno Lossin" writes: > On Tue May 6, 2025 at 3:02 PM CEST, Andreas Hindborg wrote: >> Add support for module parameters to the `module!` macro. Implement read >> only support for integer types without `sysfs` support. >> >> Acked-by: Petr Pavlu # from modules perspective >> Tested-by: Daniel G

Re: [PATCH v12 2/3] rust: add parameter support to the `module!` macro

On Tue May 6, 2025 at 3:02 PM CEST, Andreas Hindborg wrote: > Add support for module parameters to the `module!` macro. Implement read > only support for integer types without `sysfs` support. > > Acked-by: Petr Pavlu # from modules perspective > Tested-by: Daniel Gomez > Reviewed-by: Greg Kroah-