Re: [PATCH v16 05/22] mm/thp: move lru_add_page_tail func to huge_memory.c

2020-07-20 Thread Kirill A. Shutemov
On Fri, Jul 17, 2020 at 01:13:21PM +0800, Alex Shi wrote: > > > 在 2020/7/16 下午9:17, Kirill A. Shutemov 写道: > > On Thu, Jul 16, 2020 at 04:59:48PM +0800, Alex Shi wrote: > >> Hi Kirill & Matthew, > >> > >> Is there any concern from for the THP involved patches? > > > > It is mechanical move. I do

Re: [PATCH v16 05/22] mm/thp: move lru_add_page_tail func to huge_memory.c

2020-07-16 Thread Alex Shi
在 2020/7/16 下午9:17, Kirill A. Shutemov 写道: > On Thu, Jul 16, 2020 at 04:59:48PM +0800, Alex Shi wrote: >> Hi Kirill & Matthew, >> >> Is there any concern from for the THP involved patches? > > It is mechanical move. I don't see a problem. > Many thanks! Kirill, Do you mind to give a reviewed

Re: [PATCH v16 05/22] mm/thp: move lru_add_page_tail func to huge_memory.c

2020-07-16 Thread Kirill A. Shutemov
On Thu, Jul 16, 2020 at 04:59:48PM +0800, Alex Shi wrote: > Hi Kirill & Matthew, > > Is there any concern from for the THP involved patches? It is mechanical move. I don't see a problem. -- Kirill A. Shutemov

Re: [PATCH v16 05/22] mm/thp: move lru_add_page_tail func to huge_memory.c

2020-07-16 Thread Alex Shi
Hi Kirill & Matthew, Is there any concern from for the THP involved patches? Thanks Alex 在 2020/7/11 上午8:58, Alex Shi 写道: > The func is only used in huge_memory.c, defining it in other file with a > CONFIG_TRANSPARENT_HUGEPAGE macro restrict just looks weird. > > Let's move it THP. And make it