Re: [PATCH v2] HID: asus: support backlight on USB keyboards

On Thu, Apr 6, 2017 at 11:11 AM, Benjamin Tissoires wrote: > Hi Carlo, Hi Benjamin, [cut] >> +static int asus_kbd_get_report(struct hid_device *hdev, u8 *buf, size_t >> buf_size) > > Nitpick: should be asus_kbd_set_report() right :) [cut] >> +static void

Re: [PATCH v2] HID: asus: support backlight on USB keyboards

On Thu, Apr 6, 2017 at 11:11 AM, Benjamin Tissoires wrote: > Hi Carlo, Hi Benjamin, [cut] >> +static int asus_kbd_get_report(struct hid_device *hdev, u8 *buf, size_t >> buf_size) > > Nitpick: should be asus_kbd_set_report() right :) [cut] >> +static void asus_kbd_backlight_work(struct

Re: [PATCH v2] HID: asus: support backlight on USB keyboards

Hi Carlo, On Apr 05 2017 or thereabouts, Carlo Caione wrote: > From: Carlo Caione > > The latest USB keyboards shipped on several ASUS laptop models > (including ROG laptop models such as GL702VMK) have the keyboards > backlight controlled by the keyboard firmware. > > The

Re: [PATCH v2] HID: asus: support backlight on USB keyboards

Hi Carlo, On Apr 05 2017 or thereabouts, Carlo Caione wrote: > From: Carlo Caione > > The latest USB keyboards shipped on several ASUS laptop models > (including ROG laptop models such as GL702VMK) have the keyboards > backlight controlled by the keyboard firmware. > > The firmware implements