Re: [PATCH v2] Revert "mm/page_alloc: fix memmap_init_zone pageblock alignment"

2018-03-18 Thread Neil Armstrong
On 14/03/2018 23:53, Shanker Donthineni wrote: > > Hi Ard, > > On 03/14/2018 05:25 PM, Jan Glauber wrote: >> On Wed, Mar 14, 2018 at 07:29:37PM +, Ard Biesheuvel wrote: >>> This reverts commit 864b75f9d6b0100bb24fdd9a20d156e7cda9b5ae. >> >> FWIW, the revert fixes the boot hang I'm seeing on T

Re: [PATCH v2] Revert "mm/page_alloc: fix memmap_init_zone pageblock alignment"

2018-03-15 Thread Michal Hocko
On Thu 15-03-18 11:28:27, Linus Torvalds wrote: > On Thu, Mar 15, 2018 at 11:21 AM, Michal Hocko wrote: > > > > Well, pfn_valid says that a given pfn is backed by a real memory and it > > has a valid struct page backing it. > > No, it really just says the latter. There should be a "struct page" f

Re: [PATCH v2] Revert "mm/page_alloc: fix memmap_init_zone pageblock alignment"

2018-03-15 Thread Linus Torvalds
On Thu, Mar 15, 2018 at 11:21 AM, Michal Hocko wrote: > > Well, pfn_valid says that a given pfn is backed by a real memory and it > has a valid struct page backing it. No, it really just says the latter. There should be a "struct page" for it. It may not be "real memory". The struct page might h

Re: [PATCH v2] Revert "mm/page_alloc: fix memmap_init_zone pageblock alignment"

2018-03-15 Thread Michal Hocko
On Thu 15-03-18 15:48:47, Ard Biesheuvel wrote: > On 15 March 2018 at 15:34, Daniel Vacek wrote: [...] > > Hence I was asking what is the abstract meaning > > of it. As I see two *way_different* implementations so I am not sure > > how I should understand that. > > > > My interpretation is that i

Re: [PATCH v2] Revert "mm/page_alloc: fix memmap_init_zone pageblock alignment"

2018-03-15 Thread Ard Biesheuvel
On 15 March 2018 at 15:34, Daniel Vacek wrote: > On Thu, Mar 15, 2018 at 4:17 PM, Ard Biesheuvel > wrote: >> On 15 March 2018 at 15:12, Daniel Vacek wrote: >>> On Thu, Mar 15, 2018 at 8:45 AM, Ard Biesheuvel >>> wrote: On 15 March 2018 at 07:44, Daniel Vacek wrote: > On Thu, Mar 15, 2

Re: [PATCH v2] Revert "mm/page_alloc: fix memmap_init_zone pageblock alignment"

2018-03-15 Thread Daniel Vacek
On Thu, Mar 15, 2018 at 4:17 PM, Ard Biesheuvel wrote: > On 15 March 2018 at 15:12, Daniel Vacek wrote: >> On Thu, Mar 15, 2018 at 8:45 AM, Ard Biesheuvel >> wrote: >>> On 15 March 2018 at 07:44, Daniel Vacek wrote: On Thu, Mar 15, 2018 at 8:36 AM, Ard Biesheuvel wrote: > On 15 M

Re: [PATCH v2] Revert "mm/page_alloc: fix memmap_init_zone pageblock alignment"

2018-03-15 Thread Ard Biesheuvel
On 15 March 2018 at 15:12, Daniel Vacek wrote: > On Thu, Mar 15, 2018 at 8:45 AM, Ard Biesheuvel > wrote: >> On 15 March 2018 at 07:44, Daniel Vacek wrote: >>> On Thu, Mar 15, 2018 at 8:36 AM, Ard Biesheuvel >>> wrote: On 15 March 2018 at 02:23, Daniel Vacek wrote: > On Wed, Mar 14, 2

Re: [PATCH v2] Revert "mm/page_alloc: fix memmap_init_zone pageblock alignment"

2018-03-15 Thread Daniel Vacek
On Thu, Mar 15, 2018 at 8:45 AM, Ard Biesheuvel wrote: > On 15 March 2018 at 07:44, Daniel Vacek wrote: >> On Thu, Mar 15, 2018 at 8:36 AM, Ard Biesheuvel >> wrote: >>> On 15 March 2018 at 02:23, Daniel Vacek wrote: On Wed, Mar 14, 2018 at 8:29 PM, Ard Biesheuvel wrote: > This re

Re: [PATCH v2] Revert "mm/page_alloc: fix memmap_init_zone pageblock alignment"

2018-03-15 Thread Ard Biesheuvel
On 15 March 2018 at 07:44, Daniel Vacek wrote: > On Thu, Mar 15, 2018 at 8:36 AM, Ard Biesheuvel > wrote: >> On 15 March 2018 at 02:23, Daniel Vacek wrote: >>> On Wed, Mar 14, 2018 at 8:29 PM, Ard Biesheuvel >>> wrote: This reverts commit 864b75f9d6b0100bb24fdd9a20d156e7cda9b5ae.

Re: [PATCH v2] Revert "mm/page_alloc: fix memmap_init_zone pageblock alignment"

2018-03-15 Thread Daniel Vacek
On Thu, Mar 15, 2018 at 8:36 AM, Ard Biesheuvel wrote: > On 15 March 2018 at 02:23, Daniel Vacek wrote: >> On Wed, Mar 14, 2018 at 8:29 PM, Ard Biesheuvel >> wrote: >>> This reverts commit 864b75f9d6b0100bb24fdd9a20d156e7cda9b5ae. >>> >>> Commit 864b75f9d6b0 ("mm/page_alloc: fix memmap_init_zone

Re: [PATCH v2] Revert "mm/page_alloc: fix memmap_init_zone pageblock alignment"

2018-03-15 Thread Ard Biesheuvel
On 15 March 2018 at 02:23, Daniel Vacek wrote: > On Wed, Mar 14, 2018 at 8:29 PM, Ard Biesheuvel > wrote: >> This reverts commit 864b75f9d6b0100bb24fdd9a20d156e7cda9b5ae. >> >> Commit 864b75f9d6b0 ("mm/page_alloc: fix memmap_init_zone pageblock >> alignment") modified the logic in memmap_init_zon

Re: [PATCH v2] Revert "mm/page_alloc: fix memmap_init_zone pageblock alignment"

2018-03-14 Thread Daniel Vacek
On Wed, Mar 14, 2018 at 8:29 PM, Ard Biesheuvel wrote: > This reverts commit 864b75f9d6b0100bb24fdd9a20d156e7cda9b5ae. > > Commit 864b75f9d6b0 ("mm/page_alloc: fix memmap_init_zone pageblock > alignment") modified the logic in memmap_init_zone() to initialize > struct pages associated with invalid

Re: [PATCH v2] Revert "mm/page_alloc: fix memmap_init_zone pageblock alignment"

2018-03-14 Thread Linus Torvalds
On Wed, Mar 14, 2018 at 12:29 PM, Ard Biesheuvel wrote: > This reverts commit 864b75f9d6b0100bb24fdd9a20d156e7cda9b5ae. Applied directly, since we already had two confirmations of it fixing things for people. Thanks, Linus

Re: [PATCH v2] Revert "mm/page_alloc: fix memmap_init_zone pageblock alignment"

2018-03-14 Thread Shanker Donthineni
Hi Ard, On 03/14/2018 05:25 PM, Jan Glauber wrote: > On Wed, Mar 14, 2018 at 07:29:37PM +, Ard Biesheuvel wrote: >> This reverts commit 864b75f9d6b0100bb24fdd9a20d156e7cda9b5ae. > > FWIW, the revert fixes the boot hang I'm seeing on ThunderX1. > > --Jan > Thanks for this patch, it fixes t

Re: [PATCH v2] Revert "mm/page_alloc: fix memmap_init_zone pageblock alignment"

2018-03-14 Thread Jan Glauber
On Wed, Mar 14, 2018 at 07:29:37PM +, Ard Biesheuvel wrote: > This reverts commit 864b75f9d6b0100bb24fdd9a20d156e7cda9b5ae. FWIW, the revert fixes the boot hang I'm seeing on ThunderX1. --Jan > Commit 864b75f9d6b0 ("mm/page_alloc: fix memmap_init_zone pageblock > alignment") modified the log