Re: [PATCH v2] arm64: lse: fix LSE atomics with LLVM's integrated assembler

2019-10-14 Thread Will Deacon
On Tue, Oct 08, 2019 at 02:27:30PM -0700, Sami Tolvanen wrote: > Unlike gcc, clang considers each inline assembly block to be independent > and therefore, when using the integrated assembler for inline assembly, > any preambles that enable features must be repeated in each block. > > This change d

Re: [PATCH v2] arm64: lse: fix LSE atomics with LLVM's integrated assembler

2019-10-10 Thread Kees Cook
On Tue, Oct 08, 2019 at 02:27:30PM -0700, Sami Tolvanen wrote: > Unlike gcc, clang considers each inline assembly block to be independent > and therefore, when using the integrated assembler for inline assembly, > any preambles that enable features must be repeated in each block. > > This change d

Re: [PATCH v2] arm64: lse: fix LSE atomics with LLVM's integrated assembler

2019-10-09 Thread Andrew Murray
On Tue, Oct 08, 2019 at 05:01:59PM -0700, Nathan Chancellor wrote: > On Tue, Oct 08, 2019 at 04:59:25PM -0700, 'Sami Tolvanen' via Clang Built > Linux wrote: > > On Tue, Oct 8, 2019 at 4:31 PM Andrew Murray wrote: > > > This looks good to me. I can build and boot in a model with both Clang > > >

Re: [PATCH v2] arm64: lse: fix LSE atomics with LLVM's integrated assembler

2019-10-08 Thread Nathan Chancellor
On Tue, Oct 08, 2019 at 04:59:25PM -0700, 'Sami Tolvanen' via Clang Built Linux wrote: > On Tue, Oct 8, 2019 at 4:31 PM Andrew Murray wrote: > > This looks good to me. I can build and boot in a model with both Clang > > (9.0.6) and GCC (7.3.1) and boot a guest without anything going bang. > > Gr

Re: [PATCH v2] arm64: lse: fix LSE atomics with LLVM's integrated assembler

2019-10-08 Thread Sami Tolvanen
On Tue, Oct 8, 2019 at 4:31 PM Andrew Murray wrote: > This looks good to me. I can build and boot in a model with both Clang > (9.0.6) and GCC (7.3.1) and boot a guest without anything going bang. Great, thank you for testing this! > Though when I build with AS=clang, e.g. > > make ARCH=arm64 CR

Re: [PATCH v2] arm64: lse: fix LSE atomics with LLVM's integrated assembler

2019-10-08 Thread Andrew Murray
On Tue, Oct 08, 2019 at 02:27:30PM -0700, Sami Tolvanen wrote: > Unlike gcc, clang considers each inline assembly block to be independent > and therefore, when using the integrated assembler for inline assembly, > any preambles that enable features must be repeated in each block. > > This change d

Re: [PATCH v2] arm64: lse: fix LSE atomics with LLVM's integrated assembler

2019-10-08 Thread Nick Desaulniers
On Tue, Oct 8, 2019 at 2:27 PM 'Sami Tolvanen' via Clang Built Linux wrote: > > Unlike gcc, clang considers each inline assembly block to be independent > and therefore, when using the integrated assembler for inline assembly, > any preambles that enable features must be repeated in each block. >