Re: [PATCH v2] ath10k: sdio: remove redundant check in for loop

2020-11-05 Thread Kalle Valo
Alex Dewar wrote: > The for loop checks whether cur_section is NULL on every iteration, but > we know it can never be NULL as there is another check towards the > bottom of the loop body. Refactor to avoid this unnecessary check. > > Also, increment the variable i inline for clarity > > Address

Re: [PATCH v2] ath10k: sdio: remove redundant check in for loop

2020-09-29 Thread Kalle Valo
Alex Dewar writes: >> I agree. Anyone can come up with a patch? > > Hi Kalle, > > I was thinking of having a go at this. Have you applied the v2 of this > patch yet though? I couldn't see it in wireless-drivers-next. I just > don't want to have to rebase the patch if you were going to apply this

Re: [PATCH v2] ath10k: sdio: remove redundant check in for loop

2020-09-27 Thread Alex Dewar
> I agree. Anyone can come up with a patch? Hi Kalle, I was thinking of having a go at this. Have you applied the v2 of this patch yet though? I couldn't see it in wireless-drivers-next. I just don't want to have to rebase the patch if you were going to apply this v2. Best, Alex > > -- > http

Re: [PATCH v2] ath10k: sdio: remove redundant check in for loop

2020-09-24 Thread Kalle Valo
Julian Calaby writes: > On Thu, Sep 17, 2020 at 3:09 AM Alex Dewar wrote: >> >> The for loop checks whether cur_section is NULL on every iteration, but >> we know it can never be NULL as there is another check towards the >> bottom of the loop body. Refactor to avoid this unnecessary check. >> >

Re: [PATCH v2] ath10k: sdio: remove redundant check in for loop

2020-09-16 Thread Julian Calaby
Hi Alex, On Thu, Sep 17, 2020 at 3:09 AM Alex Dewar wrote: > > The for loop checks whether cur_section is NULL on every iteration, but > we know it can never be NULL as there is another check towards the > bottom of the loop body. Refactor to avoid this unnecessary check. > > Also, increment the