Re: [PATCH v2] checkpatch.pl: warn on invalid commit id

2019-07-25 Thread Andrew Morton
On Fri, 26 Jul 2019 03:17:32 +0200 Matteo Croce wrote: > > > If .git is not found, the check is disabled > > > > We could permit user to set an environment variable to tell checkpatch > > where the kernel git tree resides. > > > > Maybe GIT_DIR already does it. Yes, that works. GIT_DIR=/.git

Re: [PATCH v2] checkpatch.pl: warn on invalid commit id

2019-07-25 Thread Matteo Croce
On July 26, 2019 2:22:05 AM GMT+02:00, Andrew Morton wrote: > On Thu, 25 Jul 2019 11:26:04 +0200 Matteo Croce > wrote: > > > On Thu, Jul 25, 2019 at 5:07 AM Andrew Morton > wrote: > > > What does it do if we're not operating in a git directory? For > example, > > > I work in /usr/src/25 and my

Re: [PATCH v2] checkpatch.pl: warn on invalid commit id

2019-07-25 Thread Andrew Morton
On Thu, 25 Jul 2019 11:26:04 +0200 Matteo Croce wrote: > On Thu, Jul 25, 2019 at 5:07 AM Andrew Morton > wrote: > > What does it do if we're not operating in a git directory? For example, > > I work in /usr/src/25 and my git repo is in ../git26. > > > > If .git is not found, the check is disab

Re: [PATCH v2] checkpatch.pl: warn on invalid commit id

2019-07-25 Thread Matteo Croce
On Thu, Jul 25, 2019 at 5:07 AM Andrew Morton wrote: > What does it do if we're not operating in a git directory? For example, > I work in /usr/src/25 and my git repo is in ../git26. > If .git is not found, the check is disabled > Also, what happens relatively often is that someone quotes a linu

Re: [PATCH v2] checkpatch.pl: warn on invalid commit id

2019-07-24 Thread Andrew Morton
On Thu, 11 Jul 2019 02:16:40 +0200 Matteo Croce wrote: > It can happen that a commit message refers to an invalid commit id, because > the referenced hash changed following a rebase, or simply by mistake. > Add a check in checkpatch.pl which checks that an hash referenced by > a Fixes tag, or jus

Re: [PATCH v2] checkpatch.pl: warn on invalid commit id

2019-07-11 Thread Joe Perches
On Thu, 2019-07-11 at 02:16 +0200, Matteo Croce wrote: > It can happen that a commit message refers to an invalid commit id, because > the referenced hash changed following a rebase, or simply by mistake. > Add a check in checkpatch.pl which checks that an hash referenced by > a Fixes tag, or just