Re: [PATCH v2] cpufreq: rockchip: add driver

2016-03-24 Thread Viresh Kumar
On 24-03-16, 23:09, Finley Xiao wrote: > --- a/arch/arm64/boot/dts/rockchip/rk3366.dtsi > +++ b/arch/arm64/boot/dts/rockchip/rk3366.dtsi > + cpufreq { > + compatible = "***,***"; > + } > > Does it create a DT node for a dummy device too ? Yes, its not allowed. -- vires

Re: [PATCH v2] cpufreq: rockchip: add driver

2016-03-24 Thread Finley Xiao
Hi Viresh, can we add a of_match_table with a common compatible name as follows ? --- a/drivers/cpufreq/cpufreq-dt.c +++ b/drivers/cpufreq/cpufreq-dt.c @@ -470,10 +470,16 @@ static int dt_cpufreq_remove(struct platform_device *pdev) cpufreq_unregister_driver(&dt_cpufreq_driver);

Re: [PATCH v2] cpufreq: rockchip: add driver

2016-03-23 Thread Viresh Kumar
On 24-03-16, 11:01, Feng Xiao wrote: > hi all, > I found that it could match the cpufreq-dt driver succesfully only with > the following changes. > --- a/arch/arm64/boot/dts/rockchip/rk3366.dtsi > +++ b/arch/arm64/boot/dts/rockchip/rk3366.dtsi > @@ -139,6 +139,10 @@ > }; >

Re: [PATCH v2] cpufreq: rockchip: add driver

2016-03-23 Thread Feng Xiao
hi all, I found that it could match the cpufreq-dt driver succesfully only with the following changes. --- a/arch/arm64/boot/dts/rockchip/rk3366.dtsi +++ b/arch/arm64/boot/dts/rockchip/rk3366.dtsi @@ -139,6 +139,10 @@ }; }; + cpufreq-dt { //the node name mus

Re: [PATCH v2] cpufreq: rockchip: add driver

2016-03-22 Thread Viresh Kumar
On 23-03-16, 10:18, Feng Xiao wrote: > diff --git a/drivers/cpufreq/Kconfig.arm b/drivers/cpufreq/Kconfig.arm > index 14b1f93..1786315 100644 > --- a/drivers/cpufreq/Kconfig.arm > +++ b/drivers/cpufreq/Kconfig.arm > @@ -97,6 +97,16 @@ config ARM_OMAP2PLUS_CPUFREQ > depends on ARCH_OMAP2PLUS >