On Fri, Apr 03, 2015 at 09:29:44PM +0200, Stephan Mueller wrote:
>
> What about moving the current crypto_unregister_instance into
> __crypto_unregister_instance and creating a new crypto_unregister_instance
> that takes the ref count and once it got it, it calls
> __crypto_unregister_instance.
Am Freitag, 3. April 2015, 23:52:46 schrieb Herbert Xu:
Hi Herbert,
> On Fri, Apr 03, 2015 at 05:17:13PM +0200, Stephan Mueller wrote:
> > Wpuldn't crypto_del_alg suffer from the same issue? I see that the
> > cra_refcnt is checked. But I guess there would be the same kind of race?
>
> You're qu
On Fri, Apr 03, 2015 at 05:17:13PM +0200, Stephan Mueller wrote:
>
> Wpuldn't crypto_del_alg suffer from the same issue? I see that the cra_refcnt
> is checked. But I guess there would be the same kind of race?
You're quite right. It too needs to take a ref count on the
algorithm in crypto_alg_m
Am Freitag, 3. April 2015, 17:58:28 schrieb Herbert Xu:
Hi Herbert,
> On Thu, Apr 02, 2015 at 07:05:27PM +0200, Stephan Mueller wrote:
> > diff --git a/crypto/algapi.c b/crypto/algapi.c
> > index 83b04e0..215c604 100644
> > --- a/crypto/algapi.c
> > +++ b/crypto/algapi.c
> >
> > @@ -545,6 +545,1
On Thu, Apr 02, 2015 at 07:05:27PM +0200, Stephan Mueller wrote:
>
> diff --git a/crypto/algapi.c b/crypto/algapi.c
> index 83b04e0..215c604 100644
> --- a/crypto/algapi.c
> +++ b/crypto/algapi.c
> @@ -545,6 +545,10 @@ unlock:
> goto err;
>
> crypto_wait_for_test(larval);
> +
5 matches
Mail list logo