Re: [PATCH v2] dmaengine: edma: Implement device_synchronize callback

2016-02-21 Thread Vinod Koul
On Thu, Feb 11, 2016 at 11:08:42AM +0200, Peter Ujfalusi wrote: > We need the callback to support the dmaengine_terminate_sync(). Applied, thanks -- ~Vinod

Re: [PATCH v2] dmaengine: edma: Implement device_synchronize callback

2016-02-11 Thread Lars-Peter Clausen
On 02/11/2016 12:12 PM, Peter Ujfalusi wrote: > On 02/11/2016 11:41 AM, Lars-Peter Clausen wrote: >> On 02/11/2016 10:08 AM, Peter Ujfalusi wrote: >>> We need the callback to support the dmaengine_terminate_sync(). >>> >>> Signed-off-by: Peter Ujfalusi >> >> Looks good, but I noticed a slight race

Re: [PATCH v2] dmaengine: edma: Implement device_synchronize callback

2016-02-11 Thread Peter Ujfalusi
On 02/11/2016 11:41 AM, Lars-Peter Clausen wrote: > On 02/11/2016 10:08 AM, Peter Ujfalusi wrote: >> We need the callback to support the dmaengine_terminate_sync(). >> >> Signed-off-by: Peter Ujfalusi > > Looks good, but I noticed a slight race condition in > edma_completion_handler(). You need t

Re: [PATCH v2] dmaengine: edma: Implement device_synchronize callback

2016-02-11 Thread Lars-Peter Clausen
On 02/11/2016 10:08 AM, Peter Ujfalusi wrote: > We need the callback to support the dmaengine_terminate_sync(). > > Signed-off-by: Peter Ujfalusi Looks good, but I noticed a slight race condition in edma_completion_handler(). You need to fetch echan->desc while holding the vchan.lock. Otherwise