Re: [PATCH v2] firewire-core: remove cast of function callback

2020-05-24 Thread Greg KH
On Sun, May 24, 2020 at 10:20:48PM +0900, Takashi Sakamoto wrote: > In 1394 OHCI specification, Isochronous Receive DMA context has several > modes. One of mode is 'BufferFill' and Linux FireWire stack uses it to > receive isochronous packets for multiple isochronous channel as > FW_ISO_CONTEXT_REC

Re: [PATCH v2] firewire-core: remove cast of function callback

2020-05-24 Thread Stefan Richter
On May 24 Greg KH wrote: > On Sun, May 24, 2020 at 10:20:48PM +0900, Takashi Sakamoto wrote: > > In 1394 OHCI specification, Isochronous Receive DMA context has several > > modes. One of mode is 'BufferFill' and Linux FireWire stack uses it to > > receive isochronous packets for multiple isochronou

Re: [PATCH v2] firewire-core: remove cast of function callback

2020-05-24 Thread Takashi Sakamoto
Hi, On Mon, May 25, 2020 at 01:55:32AM +0200, Stefan Richter wrote: > > Why is this in a .h file? What's wrong with just putting it in the .c > > file as a static function? There's no need to make this an inline, > > right? > > There is no need for this in a header. > Furthermore, I prefer the