Re: [PATCH v2] input: add 2 kind of switch

2020-11-02 Thread kernel test robot
Hi HyungJae, Thank you for the patch! Yet something to improve: [auto build test ERROR on input/next] [also build test ERROR on linus/master linux/master v5.10-rc2 next-20201102] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '

Re: [PATCH v2] input: add 2 kind of switch

2020-10-29 Thread Dmitry Torokhov
On Thu, Oct 29, 2020 at 02:57:15PM +0100, gre...@linuxfoundation.org wrote: > On Thu, Oct 29, 2020 at 10:27:47PM +0900, HyungJae Im wrote: > > From: "hj2.im" > > Date: Thu, 29 Oct 2020 22:11:24 +0900 > > Subject: [PATCH v2] input: add 2 kind of switch > > Why is this in the body of that patch? >

Re: [PATCH v2] input: add 2 kind of switch

2020-10-29 Thread Barnabás Pőcze
Hi > [...] > > > diff --git a/include/linux/mod_devicetable.h > > > b/include/linux/mod_devicetable.h > > > index 5b08a473cdba..897f5a3e7721 100644 > > > --- a/include/linux/mod_devicetable.h > > > +++ b/include/linux/mod_devicetable.h > > > @@ -320,7 +320,7 @@ struct pcmcia_device_id { > > > #d

Re: [PATCH v2] input: add 2 kind of switch

2020-10-29 Thread gre...@linuxfoundation.org
On Thu, Oct 29, 2020 at 10:27:47PM +0900, HyungJae Im wrote: > From: "hj2.im" > Date: Thu, 29 Oct 2020 22:11:24 +0900 > Subject: [PATCH v2] input: add 2 kind of switch Why is this in the body of that patch? > > We need support to various accessories on the device, > some switch does not exist i

Re: [PATCH v2] input: add 2 kind of switch

2020-10-29 Thread gre...@linuxfoundation.org
On Thu, Oct 29, 2020 at 01:41:57PM +, Barnabás Pőcze wrote: > Hi > > > [...] > > diff --git a/include/linux/mod_devicetable.h > > b/include/linux/mod_devicetable.h > > index 5b08a473cdba..897f5a3e7721 100644 > > --- a/include/linux/mod_devicetable.h > > +++ b/include/linux/mod_devicetable.h >

Re: [PATCH v2] input: add 2 kind of switch

2020-10-29 Thread Barnabás Pőcze
Hi > [...] > diff --git a/include/linux/mod_devicetable.h b/include/linux/mod_devicetable.h > index 5b08a473cdba..897f5a3e7721 100644 > --- a/include/linux/mod_devicetable.h > +++ b/include/linux/mod_devicetable.h > @@ -320,7 +320,7 @@ struct pcmcia_device_id { > #define INPUT_DEVICE_ID_LED_MAX