Re: [PATCH v2] kernel: arg2 is unsigned long which is never < 0

2013-02-15 Thread Cyrill Gorcunov
On Sat, Feb 16, 2013 at 12:13:41PM +0800, Chen Gang wrote: > > arg2 will never < 0, for its type is 'unsigned long' > > so need beautify the relative source code (better to use macros). > > Reported-by: Cyrill Gorcunov > Signed-off-by: Chen Gang Looks good to me, thanks Chen! -- To unsubs

Re: [PATCH v2] kernel: arg2 is unsigned long which is never < 0

2013-02-15 Thread Kees Cook
On Fri, Feb 15, 2013 at 8:13 PM, Chen Gang wrote: > > arg2 will never < 0, for its type is 'unsigned long' > > so need beautify the relative source code (better to use macros). > > Reported-by: Cyrill Gorcunov > Signed-off-by: Chen Gang Acked-by: Kees Cook -Kees -- Kees Cook Chrome OS S