Re: [PATCH v2] kexec: Fix kdump failure with notsc

2016-07-13 Thread Baoquan He
On 07/13/16 at 07:46am, Wei, Jiangang wrote: > On Mon, 2016-07-11 at 18:28 +0800, Wei Jiangang wrote: > > Hi , Ingo > > > > On Fri, 2016-07-08 at 09:38 +0200, Ingo Molnar wrote: > > > * Eric W. Biederman wrote: > > > > > > > Sigh. Can we please just do the work to rip out the apic shutdown code

Re: [PATCH v2] kexec: Fix kdump failure with notsc

2016-07-13 Thread Wei, Jiangang
On Mon, 2016-07-11 at 18:28 +0800, Wei Jiangang wrote: > Hi , Ingo > > On Fri, 2016-07-08 at 09:38 +0200, Ingo Molnar wrote: > > * Eric W. Biederman wrote: > > > > > Sigh. Can we please just do the work to rip out the apic shutdown code > > > from the > > > kexec on panic code path? > > > >

Re: [PATCH v2] kexec: Fix kdump failure with notsc

2016-07-12 Thread Baoquan He
On 07/12/16 at 09:09am, Wei, Jiangang wrote: > On Tue, 2016-07-12 at 14:52 +0800, Xunlei Pang wrote: > > On 2016/07/07 at 18:17, Wei Jiangang wrote: > > > diff --git a/arch/x86/kernel/machine_kexec_32.c > > > b/arch/x86/kernel/machine_kexec_32.c > > > index 469b23d6acc2..c934a7868e6b 100644 > > >

Re: [PATCH v2] kexec: Fix kdump failure with notsc

2016-07-12 Thread Wei, Jiangang
On Tue, 2016-07-12 at 16:21 +0800, Baoquan He wrote: > On 07/12/16 at 02:52pm, Xunlei Pang wrote: > > On 2016/07/07 at 18:17, Wei Jiangang wrote: > > > Signed-off-by: Wei Jiangang > > > --- > > > +/* Local APIC is disabled by the kernel for crash or reboot path */ > > > +static int disabled_local_

Re: [PATCH v2] kexec: Fix kdump failure with notsc

2016-07-12 Thread Wei, Jiangang
On Tue, 2016-07-12 at 14:52 +0800, Xunlei Pang wrote: > On 2016/07/07 at 18:17, Wei Jiangang wrote: > > If we specify the 'notsc' boot parameter for the dump-capture kernel, > > and then trigger a crash(panic) by using "ALT-SysRq-c" or "echo c > > > /proc/sysrq-trigger", > > the dump-capture kernel

Re: [PATCH v2] kexec: Fix kdump failure with notsc

2016-07-12 Thread Baoquan He
On 07/12/16 at 02:52pm, Xunlei Pang wrote: > On 2016/07/07 at 18:17, Wei Jiangang wrote: > > Signed-off-by: Wei Jiangang > > --- > > +/* Local APIC is disabled by the kernel for crash or reboot path */ > > +static int disabled_local_apic; > > + > > /* > > * Knob to control our willingness to en

Re: [PATCH v2] kexec: Fix kdump failure with notsc

2016-07-11 Thread Xunlei Pang
On 2016/07/07 at 18:17, Wei Jiangang wrote: > If we specify the 'notsc' boot parameter for the dump-capture kernel, > and then trigger a crash(panic) by using "ALT-SysRq-c" or "echo c > > /proc/sysrq-trigger", > the dump-capture kernel will hang in calibrate_delay_converge(): > > /* wait for "s

Re: [PATCH v2] kexec: Fix kdump failure with notsc

2016-07-11 Thread Wei, Jiangang
Hi , Ingo On Fri, 2016-07-08 at 09:38 +0200, Ingo Molnar wrote: > * Eric W. Biederman wrote: > > > Sigh. Can we please just do the work to rip out the apic shutdown code > > from the > > kexec on panic code path? > > > > I forgetting details but the only reason we have do any apic shutdown i

Re: [PATCH v2] kexec: Fix kdump failure with notsc

2016-07-08 Thread Nikolay Borisov
On 07/07/2016 01:17 PM, Wei Jiangang wrote: > If we specify the 'notsc' boot parameter for the dump-capture kernel, > and then trigger a crash(panic) by using "ALT-SysRq-c" or "echo c > > /proc/sysrq-trigger", > the dump-capture kernel will hang in calibrate_delay_converge(): > > /* wait for

Re: [PATCH v2] kexec: Fix kdump failure with notsc

2016-07-08 Thread Ingo Molnar
* Eric W. Biederman wrote: > Sigh. Can we please just do the work to rip out the apic shutdown code from > the > kexec on panic code path? > > I forgetting details but the only reason we have do any apic shutdown is bugs > in > older kernels that could not initialize a system properly if w

Re: [PATCH v2] kexec: Fix kdump failure with notsc

2016-07-07 Thread Wei, Jiangang
Hi , Eric Thanks for your comments firstly. On Thu, 2016-07-07 at 12:55 -0500, Eric W. Biederman wrote: > Wei Jiangang writes: > > > If we specify the 'notsc' boot parameter for the dump-capture kernel, > > and then trigger a crash(panic) by using "ALT-SysRq-c" or "echo c > > > /proc/sysrq-trig

Re: [PATCH v2] kexec: Fix kdump failure with notsc

2016-07-07 Thread Eric W. Biederman
Wei Jiangang writes: > If we specify the 'notsc' boot parameter for the dump-capture kernel, > and then trigger a crash(panic) by using "ALT-SysRq-c" or "echo c > > /proc/sysrq-trigger", > the dump-capture kernel will hang in calibrate_delay_converge(): > > /* wait for "start of" clock tick *