Re: [PATCH v2] mm: memblock: fix wrong memmove size in memblock_merge_regions()

2013-01-07 Thread Lin Feng
On 01/08/2013 05:23 AM, Andrew Morton wrote: > On Mon, 7 Jan 2013 11:41:36 +0800 > Lin Feng wrote: > >> The memmove span covers from (next+1) to the end of the array, and the index >> of next is (i+1), so the index of (next+1) is (i+2). So the size of remaining >> array elements is (type->cnt -

Re: [PATCH v2] mm: memblock: fix wrong memmove size in memblock_merge_regions()

2013-01-07 Thread Andrew Morton
On Mon, 7 Jan 2013 11:41:36 +0800 Lin Feng wrote: > The memmove span covers from (next+1) to the end of the array, and the index > of next is (i+1), so the index of (next+1) is (i+2). So the size of remaining > array elements is (type->cnt - (i + 2)). What are the user-visible effects of this bu

Re: [PATCH v2] mm: memblock: fix wrong memmove size in memblock_merge_regions()

2013-01-07 Thread Tejun Heo
On Mon, Jan 07, 2013 at 11:41:36AM +0800, Lin Feng wrote: > The memmove span covers from (next+1) to the end of the array, and the index > of next is (i+1), so the index of (next+1) is (i+2). So the size of remaining > array elements is (type->cnt - (i + 2)). > > Cc: Tejun Heo > Reviewed-by: Wanp