Re: [PATCH v2] mm: memcontrol: fix possible memcg leak due to interrupted reclaim

2015-12-23 Thread Johannes Weiner
I think we can fold the following in there as well: >From b885bf06f55d05f0e8249357d4edb231dfe4a5dc Mon Sep 17 00:00:00 2001 From: Johannes Weiner Date: Wed, 23 Dec 2015 17:16:07 -0500 Subject: [PATCH] mm: memcontrol: fix possible memcg leak due to interrupted reclaim fix When we handled multipl

Re: [PATCH v2] mm: memcontrol: fix possible memcg leak due to interrupted reclaim

2015-12-19 Thread Vladimir Davydov
On Fri, Dec 18, 2015 at 02:40:04PM -0800, Andrew Morton wrote: > On Fri, 18 Dec 2015 19:24:05 +0300 Vladimir Davydov > wrote: > > > > > OK, got it, thanks. Here goes the incremental patch (it should also fix > > the warning regarding unused cmpxchg returned value): > > --- > > diff --git a/mm/m

Re: [PATCH v2] mm: memcontrol: fix possible memcg leak due to interrupted reclaim

2015-12-18 Thread Andrew Morton
On Fri, 18 Dec 2015 19:24:05 +0300 Vladimir Davydov wrote: > > OK, got it, thanks. Here goes the incremental patch (it should also fix > the warning regarding unused cmpxchg returned value): > --- > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > index fc25dc211eaf..908c075e04eb 100644 > --- a

Re: [PATCH v2] mm: memcontrol: fix possible memcg leak due to interrupted reclaim

2015-12-18 Thread Vladimir Davydov
On Fri, Dec 18, 2015 at 11:00:41AM -0500, Johannes Weiner wrote: > On Fri, Dec 18, 2015 at 06:32:02PM +0300, Vladimir Davydov wrote: > > On Thu, Dec 17, 2015 at 03:02:17PM -0800, Andrew Morton wrote: > > > On Tue, 15 Dec 2015 15:31:37 +0300 Vladimir Davydov > > > wrote: > > > > @@ -859,14 +859,20

Re: [PATCH v2] mm: memcontrol: fix possible memcg leak due to interrupted reclaim

2015-12-18 Thread Johannes Weiner
On Fri, Dec 18, 2015 at 06:32:02PM +0300, Vladimir Davydov wrote: > On Thu, Dec 17, 2015 at 03:02:17PM -0800, Andrew Morton wrote: > > On Tue, 15 Dec 2015 15:31:37 +0300 Vladimir Davydov > > wrote: > > > @@ -859,14 +859,20 @@ struct mem_cgroup *mem_cgroup_iter(struct > > > mem_cgroup *root, > >

Re: [PATCH v2] mm: memcontrol: fix possible memcg leak due to interrupted reclaim

2015-12-18 Thread Vladimir Davydov
On Thu, Dec 17, 2015 at 03:02:17PM -0800, Andrew Morton wrote: > On Tue, 15 Dec 2015 15:31:37 +0300 Vladimir Davydov > wrote: > > > Memory cgroup reclaim can be interrupted with mem_cgroup_iter_break() > > once enough pages have been reclaimed, in which case, in contrast to a > > full round-trip

Re: [PATCH v2] mm: memcontrol: fix possible memcg leak due to interrupted reclaim

2015-12-17 Thread Andrew Morton
On Tue, 15 Dec 2015 15:31:37 +0300 Vladimir Davydov wrote: > Memory cgroup reclaim can be interrupted with mem_cgroup_iter_break() > once enough pages have been reclaimed, in which case, in contrast to a > full round-trip over a cgroup sub-tree, the current position stored in > mem_cgroup_reclai

Re: [PATCH v2] mm: memcontrol: fix possible memcg leak due to interrupted reclaim

2015-12-15 Thread Johannes Weiner
On Tue, Dec 15, 2015 at 03:31:37PM +0300, Vladimir Davydov wrote: > Memory cgroup reclaim can be interrupted with mem_cgroup_iter_break() > once enough pages have been reclaimed, in which case, in contrast to a > full round-trip over a cgroup sub-tree, the current position stored in > mem_cgroup_re