Re: [PATCH v2] mm: teach dump_page() to correctly output poisoned struct pages

2018-07-02 Thread Andrew Morton
On Mon, 2 Jul 2018 14:05:36 -0400 Pavel Tatashin wrote: > If struct page is poisoned, and uninitialized access is detected via > PF_POISONED_CHECK(page) dump_page() is called to output the page. But, > the dump_page() itself accesses struct page to determine how to print > it, and therefore

Re: [PATCH v2] mm: teach dump_page() to correctly output poisoned struct pages

2018-07-02 Thread Andrew Morton
On Mon, 2 Jul 2018 14:05:36 -0400 Pavel Tatashin wrote: > If struct page is poisoned, and uninitialized access is detected via > PF_POISONED_CHECK(page) dump_page() is called to output the page. But, > the dump_page() itself accesses struct page to determine how to print > it, and therefore

Re: [PATCH v2] mm: teach dump_page() to correctly output poisoned struct pages

2018-07-02 Thread Michal Hocko
On Mon 02-07-18 14:05:36, Pavel Tatashin wrote: [...] > void __dump_page(struct page *page, const char *reason) > { > + bool page_poisoned = PagePoisoned(page); > + int mapcount; > + > + /* > + * If struct page is poisoned don't access Page*() functions as that > + * leads

Re: [PATCH v2] mm: teach dump_page() to correctly output poisoned struct pages

2018-07-02 Thread Michal Hocko
On Mon 02-07-18 14:05:36, Pavel Tatashin wrote: [...] > void __dump_page(struct page *page, const char *reason) > { > + bool page_poisoned = PagePoisoned(page); > + int mapcount; > + > + /* > + * If struct page is poisoned don't access Page*() functions as that > + * leads