Re: [PATCH v2] printk: Use the main logbuf in NMI when logbuf_lock is available

2017-05-20 Thread Sergey Senozhatsky
On (05/19/17 15:02), Petr Mladek wrote: > > [..] > > > > > the problem is that > > > > > > `PRINTK_NMI_CONTEXT_MASK || PRINTK_NMI_DEFERRED_CONTEXT_MASK' is 0x01 > > > > d'oh... forgot to copy-paste this... > > Grrr, thanks a lot for chasing this down and I am sorry for the troubles. no worri

Re: [PATCH v2] printk: Use the main logbuf in NMI when logbuf_lock is available

2017-05-19 Thread Petr Mladek
On Fri 2017-05-19 13:38:15, Sergey Senozhatsky wrote: > On (05/19/17 11:58), Sergey Senozhatsky wrote: > > > void printk_nmi_exit(void) > > > { > > > - this_cpu_and(printk_context, ~PRINTK_NMI_CONTEXT_MASK); > > > + this_cpu_and(printk_context, > > > + ~(PRINTK_NMI_CONTEXT_MASK || >

Re: [PATCH v2] printk: Use the main logbuf in NMI when logbuf_lock is available

2017-05-18 Thread Sergey Senozhatsky
On (05/19/17 11:58), Sergey Senozhatsky wrote: > > void printk_nmi_exit(void) > > { > > - this_cpu_and(printk_context, ~PRINTK_NMI_CONTEXT_MASK); > > + this_cpu_and(printk_context, > > +~(PRINTK_NMI_CONTEXT_MASK || > > + PRINTK_NMI_DEFERRED_CONTEXT_MASK)); > >

Re: [PATCH v2] printk: Use the main logbuf in NMI when logbuf_lock is available

2017-05-18 Thread Sergey Senozhatsky
Petr, On (05/04/17 17:46), Petr Mladek wrote: [..] > +#define PRINTK_SAFE_CONTEXT_MASK 0x3fff > +#define PRINTK_NMI_DEFERRED_CONTEXT_MASK 0x4000 > +#define PRINTK_NMI_CONTEXT_MASK 0x8000 [..] > void printk_nmi_enter(void) > { > - this_cpu_or(printk_context, PRI

Re: [PATCH v2] printk: Use the main logbuf in NMI when logbuf_lock is available

2017-05-17 Thread Petr Mladek
On Fri 2017-05-05 11:21:41, Sergey Senozhatsky wrote: > On (05/04/17 17:46), Petr Mladek wrote: > [..] > > Suggested-by: Sergey Senozhatsky > > Signed-off-by: Petr Mladek > > Acked-by: Sergey Senozhatsky Thanks for ack. > a small nitpick, > > [..] > > void printk_nmi_enter(void) > > { > >

Re: [PATCH v2] printk: Use the main logbuf in NMI when logbuf_lock is available

2017-05-04 Thread Sergey Senozhatsky
On (05/04/17 17:46), Petr Mladek wrote: [..] > Suggested-by: Sergey Senozhatsky > Signed-off-by: Petr Mladek Acked-by: Sergey Senozhatsky a small nitpick, [..] > void printk_nmi_enter(void) > { > - this_cpu_or(printk_context, PRINTK_NMI_CONTEXT_MASK); > + /* > + * The size of t