Re: [PATCH v2] regmap: irq: fix ack-invert

2018-03-09 Thread Tim Harvey
On Wed, Mar 7, 2018 at 6:36 AM, Mark Brown wrote: > On Tue, Mar 06, 2018 at 06:57:49AM -0800, Tony Lindgren wrote: > >> > By using regmap_irq_update_bits to ACK the interrupts we use the masked >> > status bits so we take care not to affect any other bits then use >> > ack_invert to determine if w

Re: [PATCH v2] regmap: irq: fix ack-invert

2018-03-07 Thread Mark Brown
On Tue, Mar 06, 2018 at 06:57:49AM -0800, Tony Lindgren wrote: > > By using regmap_irq_update_bits to ACK the interrupts we use the masked > > status bits so we take care not to affect any other bits then use > > ack_invert to determine if we clear or set those bits. > This change to use regmap_i

Re: [PATCH v2] regmap: irq: fix ack-invert

2018-03-06 Thread Tony Lindgren
Hi, * Tim Harvey [180305 20:59]: > When acking irqs we need to take into account the ack-invert case. > Without this chips that require 0's to ACK interrupts will never clear > the interrupt. > > By using regmap_irq_update_bits to ACK the interrupts we use the masked > status bits so we take car