Re: [PATCH v2] retpoline/module: Warn for missing retpoline in module

2018-01-16 Thread Thomas Gleixner
On Tue, 16 Jan 2018, Andi Kleen wrote: > Thanks. > > I just sent a v3 that changes the VERMAGIC only, based on Greg's > earlier feedback. > > It has the drawbacks that it: > - refuses loading instead of warns > - doesn't stop refusing when the feature is runtime disabled > > But it's much simp

RE: [PATCH v2] retpoline/module: Warn for missing retpoline in module

2018-01-16 Thread Van De Ven, Arjan
> I just sent a v3 that changes the VERMAGIC only, based on Greg's > earlier feedback. > > It has the drawbacks that it: > - refuses loading instead of warns > - doesn't stop refusing when the feature is runtime disabled > > But it's much simpler, just a few lines of ifdef. I think simple is goo

Re: [PATCH v2] retpoline/module: Warn for missing retpoline in module

2018-01-16 Thread Andi Kleen
Thanks. I just sent a v3 that changes the VERMAGIC only, based on Greg's earlier feedback. It has the drawbacks that it: - refuses loading instead of warns - doesn't stop refusing when the feature is runtime disabled But it's much simpler, just a few lines of ifdef. We can either go with the v

Re: [PATCH v2] retpoline/module: Warn for missing retpoline in module

2018-01-16 Thread Thomas Gleixner
On Fri, 12 Jan 2018, Andi Kleen wrote: > From: Andi Kleen > void stop_this_cpu(void *dummy); > void df_debug(struct pt_regs *regs, long error_code); > + > +void disable_retpoline(void); > +bool retpoline_enabled(void); Can you please use a consistent name space? retpoline_ ... or such? > +/* A