On 13 December 2017 at 20:23, Alexandre Belloni
wrote:
> On 13/12/2017 at 12:16:03 +, Mark Brown wrote:
>> On Wed, Dec 13, 2017 at 12:04:26PM +0100, Alexandre Belloni wrote:
>>
>> > Also, I think we could try having only the time64_t in the ring buffer.
>> > Maybe I'm wrong but I think tools r
On Wed, 13 Dec 2017 09:33:23 +0100
Arnd Bergmann wrote:
> >> How bad would that be to change it later? I didn't follow the whole
> >> tracepoint ABI issue closely.
>
> There is no general rule here other than "if it breaks for existing
> users, we have to fix it". Anyone who uses the tracepoi
On Wed, 13 Dec 2017 12:16:03 +
Mark Brown wrote:
> On Wed, Dec 13, 2017 at 12:04:26PM +0100, Alexandre Belloni wrote:
>
> > Also, I think we could try having only the time64_t in the ring buffer.
> > Maybe I'm wrong but I think tools reading that buffer can do the
> > conversion themselves.
On 13/12/2017 at 12:16:03 +, Mark Brown wrote:
> On Wed, Dec 13, 2017 at 12:04:26PM +0100, Alexandre Belloni wrote:
>
> > Also, I think we could try having only the time64_t in the ring buffer.
> > Maybe I'm wrong but I think tools reading that buffer can do the
> > conversion themselves. Mayb
On Wed, Dec 13, 2017 at 12:04:26PM +0100, Alexandre Belloni wrote:
> Also, I think we could try having only the time64_t in the ring buffer.
> Maybe I'm wrong but I think tools reading that buffer can do the
> conversion themselves. Maybe I don't understand correctly how
> tracepoints work and thi
On 13/12/2017 at 09:33:23 +0100, Arnd Bergmann wrote:
> On Wed, Dec 13, 2017 at 6:47 AM, Baolin Wang wrote:
> >
> >>> diff --git a/include/trace/events/rtc.h b/include/trace/events/rtc.h
> >>> new file mode 100644
> >>> index 000..b5a4add
> >>> --- /dev/null
> >>> +++ b/include/trace/events/rt
On Wed, Dec 13, 2017 at 6:47 AM, Baolin Wang wrote:
>
>>> diff --git a/include/trace/events/rtc.h b/include/trace/events/rtc.h
>>> new file mode 100644
>>> index 000..b5a4add
>>> --- /dev/null
>>> +++ b/include/trace/events/rtc.h
>>> +
>>
>> Also, I'm a bit concerned about having a struct rtc_
Hi Alexandre,
On 13 December 2017 at 06:16, Alexandre Belloni
wrote:
> Hi Baolin,
>
> On 16/11/2017 at 13:59:28 +0800, Baolin Wang wrote:
>> @@ -779,6 +797,7 @@ static int rtc_timer_enqueue(struct rtc_device *rtc,
>> struct rtc_timer *timer)
>> }
>>
>> timerqueue_add(&rtc->timerqueue
Hi Baolin,
On 16/11/2017 at 13:59:28 +0800, Baolin Wang wrote:
> @@ -779,6 +797,7 @@ static int rtc_timer_enqueue(struct rtc_device *rtc,
> struct rtc_timer *timer)
> }
>
> timerqueue_add(&rtc->timerqueue, &timer->node);
> + trace_rtc_timer_enqueue(timer);
This doesn't apply be
Hi Alexandre and Ingo,
On 16 November 2017 at 13:59, Baolin Wang wrote:
> It will be more helpful to add some tracepoints to track RTC actions when
> debugging RTC driver. Below sample is that we set/read the RTC time, then
> set 2 alarms, so we can see the trace logs:
>
> set/read RTC time:
> kw
10 matches
Mail list logo
