Re: [PATCH v2] rust: add `module_params` macro

Hi Trevor, Thanks a lot for the thorough review! "Trevor Gross" writes: > On Mon, Aug 19, 2024 at 8:35 AM Andreas Hindborg wrote: >> >> From: Andreas Hindborg >> >> This patch includes changes required for Rust kernel modules to utilize >> module parameters. This code implements read only s

Re: [PATCH v2] rust: add `module_params` macro

"Trevor Gross" writes: > On Tue, Aug 27, 2024 at 10:00 AM Andreas Hindborg wrote: >> >> "Trevor Gross" writes: >> >> > On Mon, Aug 19, 2024 at 8:35 AM Andreas Hindborg wrote: >> >> >> >> From: Andreas Hindborg >> >> >> >> This patch includes changes required for Rust kernel modules to utilize

Re: [PATCH v2] rust: add `module_params` macro

On Tue, Aug 27, 2024 at 10:00 AM Andreas Hindborg wrote: > > "Trevor Gross" writes: > > > On Mon, Aug 19, 2024 at 8:35 AM Andreas Hindborg wrote: > >> > >> From: Andreas Hindborg > >> > >> This patch includes changes required for Rust kernel modules to utilize > >> module parameters. This code

Re: [PATCH v2] rust: add `module_params` macro

"Trevor Gross" writes: > On Mon, Aug 19, 2024 at 8:35 AM Andreas Hindborg wrote: >> >> From: Andreas Hindborg >> >> This patch includes changes required for Rust kernel modules to utilize >> module parameters. This code implements read only support for integer >> types without `sysfs` support.

Re: [PATCH v2] rust: add `module_params` macro

On 24.08.24 23:23, Trevor Gross wrote: > On Sat, Aug 24, 2024 at 8:16 AM Benno Lossin wrote: >>> We shouldn't enable `const_mut_refs`. It is indeed close to >>> stabilization, but it is still kind of churny right now and we don't >>> want to enable the sharp edges everywhere. >>> >>> If the change

Re: [PATCH v2] rust: add `module_params` macro

On Sat, Aug 24, 2024 at 8:16 AM Benno Lossin wrote: > > We shouldn't enable `const_mut_refs`. It is indeed close to > > stabilization, but it is still kind of churny right now and we don't > > want to enable the sharp edges everywhere. > > > > If the change from `static mut` to `UnsafeCell` that I

Re: [PATCH v2] rust: add `module_params` macro

On 24.08.24 13:27, Trevor Gross wrote: > On Mon, Aug 19, 2024 at 8:35 AM Andreas Hindborg wrote: >> From: Andreas Hindborg >> +write!( >> +self.param_buffer, >> +" >> +static mut __{name}_{param_name}_value: {param_type} = >

Re: [PATCH v2] rust: add `module_params` macro

On Mon, Aug 19, 2024 at 8:35 AM Andreas Hindborg wrote: > > From: Andreas Hindborg > > This patch includes changes required for Rust kernel modules to utilize > module parameters. This code implements read only support for integer > types without `sysfs` support. Also, I think the subject line n

Re: [PATCH v2] rust: add `module_params` macro

On Mon, Aug 19, 2024 at 8:35 AM Andreas Hindborg wrote: > > From: Andreas Hindborg > > This patch includes changes required for Rust kernel modules to utilize > module parameters. This code implements read only support for integer > types without `sysfs` support. > diff --git a/rust/kernel/modul