Re: [PATCH v2] s390: vfio-ap: remove unnecessary calls to disable queue interrupts

2019-09-05 Thread Halil Pasic
On Thu, 5 Sep 2019 12:26:15 -0400 Tony Krowiak wrote: > On 8/30/19 12:02 PM, Halil Pasic wrote: [..] > >> @@ -1177,7 +1179,18 @@ static int vfio_ap_mdev_reset_queues(struct > >> mdev_device *mdev) > >> */ > >>if (ret) > >>rc = r

Re: [PATCH v2] s390: vfio-ap: remove unnecessary calls to disable queue interrupts

2019-09-05 Thread Tony Krowiak
On 8/30/19 12:02 PM, Halil Pasic wrote: On Mon, 19 Aug 2019 13:48:49 -0400 Tony Krowiak wrote: When an AP queue is reset (zeroized), interrupts are disabled. The queue reset function currently tries to disable interrupts unnecessarily. This patch removes the unnecessary calls to disable interr

Re: [PATCH v2] s390: vfio-ap: remove unnecessary calls to disable queue interrupts

2019-09-05 Thread Halil Pasic
On Wed, 4 Sep 2019 11:05:24 -0400 Tony Krowiak wrote: > On 9/4/19 3:35 AM, Christian Borntraeger wrote: > > Halil, > > > > can you also send this patch as a separate mail. This also requires a much > > better > > patch description about the why and it certainly should also have an > > agreemen

Re: [PATCH v2] s390: vfio-ap: remove unnecessary calls to disable queue interrupts

2019-09-05 Thread Halil Pasic
On Wed, 4 Sep 2019 09:35:47 +0200 Christian Borntraeger wrote: > Halil, > > can you also send this patch as a separate mail. This also requires a much > better > patch description about the why and it certainly should also have an > agreement from > Anthony. > IMHO this patch only makes sen

Re: [PATCH v2] s390: vfio-ap: remove unnecessary calls to disable queue interrupts

2019-09-04 Thread Tony Krowiak
On 9/4/19 3:35 AM, Christian Borntraeger wrote: Halil, can you also send this patch as a separate mail. This also requires a much better patch description about the why and it certainly should also have an agreement from Anthony. On 30.08.19 18:02, Halil Pasic wrote: From: Halil Pasic Date:

Re: [PATCH v2] s390: vfio-ap: remove unnecessary calls to disable queue interrupts

2019-09-04 Thread Christian Borntraeger
Halil, can you also send this patch as a separate mail. This also requires a much better patch description about the why and it certainly should also have an agreement from Anthony. On 30.08.19 18:02, Halil Pasic wrote: > From: Halil Pasic > Date: Fri, 30 Aug 2019 17:39:47 +0200 > Subject: [PA

Re: [PATCH v2] s390: vfio-ap: remove unnecessary calls to disable queue interrupts

2019-09-03 Thread Christian Borntraeger
On 30.08.19 18:02, Halil Pasic wrote: > From: Halil Pasic > Date: Fri, 30 Aug 2019 16:03:42 +0200 > Subject: [PATCH 1/2] s390: vfio-ap: fix warning reset not completed > > The intention seems to be to warn once when we don't wait enough for the > reset to complete. Let's use the right retry c

Re: [PATCH v2] s390: vfio-ap: remove unnecessary calls to disable queue interrupts

2019-08-30 Thread Halil Pasic
On Mon, 19 Aug 2019 13:48:49 -0400 Tony Krowiak wrote: > When an AP queue is reset (zeroized), interrupts are disabled. The queue > reset function currently tries to disable interrupts unnecessarily. This patch > removes the unnecessary calls to disable interrupts after queue reset. > > Signed-o

Re: [PATCH v2] s390: vfio-ap: remove unnecessary calls to disable queue interrupts

2019-08-19 Thread Cornelia Huck
On Mon, 19 Aug 2019 13:48:49 -0400 Tony Krowiak wrote: > When an AP queue is reset (zeroized), interrupts are disabled. The queue > reset function currently tries to disable interrupts unnecessarily. This patch > removes the unnecessary calls to disable interrupts after queue reset. > > Signed-o