Re: [PATCH v2] sched: Warn on long periods of pending need_resched

2021-04-19 Thread Peter Zijlstra
On Fri, Apr 16, 2021 at 02:33:27PM -0700, Josh Don wrote: > Yikes, sorry about that. I've squashed the fixup and sent the updated > patch (with trimmed cc list): https://lkml.org/lkml/2021/4/16/1125 For future reference, please use: https://lkml.kernel.org/r/MSGID Then I can search for MSGID in m

Re: [PATCH v2] sched: Warn on long periods of pending need_resched

2021-04-16 Thread Josh Don
On Fri, Apr 16, 2021 at 8:05 AM Peter Zijlstra wrote: > > On Tue, Mar 30, 2021 at 03:44:12PM -0700, Josh Don wrote: > > Peter, > > > > Since you've already pulled the need_resched warning patch into your > > tree, I'm including just the diff based on that patch (in response to > > Mel's comments)

Re: [PATCH v2] sched: Warn on long periods of pending need_resched

2021-04-16 Thread Peter Zijlstra
On Tue, Mar 30, 2021 at 03:44:12PM -0700, Josh Don wrote: > Peter, > > Since you've already pulled the need_resched warning patch into your > tree, I'm including just the diff based on that patch (in response to > Mel's comments) below. This should be squashed into the original > patch. > Sorry,

Re: [PATCH v2] sched: Warn on long periods of pending need_resched

2021-03-30 Thread Josh Don
Peter, Since you've already pulled the need_resched warning patch into your tree, I'm including just the diff based on that patch (in response to Mel's comments) below. This should be squashed into the original patch. Thanks, Josh --- >From 85796b4d299b1cf3f99bde154a356ce1061221b7 Mon Sep 17 00:

Re: [PATCH v2] sched: Warn on long periods of pending need_resched

2021-03-26 Thread Peter Zijlstra
On Thu, Mar 25, 2021 at 02:58:52PM -0700, Josh Don wrote: > > On Wed, Mar 24, 2021 at 01:39:16PM +, Mel Gorman wrote: > > I'm not going to NAK because I do not have hard data that shows they must > > exist. However, I won't ACK either because I bet a lot of tasty beverages > > the next time we

Re: [PATCH v2] sched: Warn on long periods of pending need_resched

2021-03-25 Thread Josh Don
> On Wed, Mar 24, 2021 at 01:39:16PM +, Mel Gorman wrote: > I'm not going to NAK because I do not have hard data that shows they must > exist. However, I won't ACK either because I bet a lot of tasty beverages > the next time we meet that the following parameters will generate reports > if remo

Re: [PATCH v2] sched: Warn on long periods of pending need_resched

2021-03-25 Thread Josh Don
On Wed, Mar 24, 2021 at 4:27 AM Mel Gorman wrote: > > I'm not a fan of the name. I know other sysctls have _enabled in the > name but it's redundant. If you say the name out loud, it sounds weird. > I would suggest an alternative but see below. Now using the version rebased by Peter; this control

Re: [PATCH v2] sched: Warn on long periods of pending need_resched

2021-03-24 Thread Mel Gorman
On Wed, Mar 24, 2021 at 03:36:14PM +0100, Peter Zijlstra wrote: > On Wed, Mar 24, 2021 at 01:39:16PM +, Mel Gorman wrote: > > > > Yeah, lets say I was pleasantly surprised to find it there :-) > > > > > > > Minimally, lets move that out before it gets kicked out. Patch below. > > OK, stuck

Re: [PATCH v2] sched: Warn on long periods of pending need_resched

2021-03-24 Thread Peter Zijlstra
On Wed, Mar 24, 2021 at 01:39:16PM +, Mel Gorman wrote: > > Yeah, lets say I was pleasantly surprised to find it there :-) > > > > Minimally, lets move that out before it gets kicked out. Patch below. OK, stuck that in front. > > > Moving something like sched_min_granularity_ns will break

Re: [PATCH v2] sched: Warn on long periods of pending need_resched

2021-03-24 Thread Mel Gorman
On Wed, Mar 24, 2021 at 01:12:16PM +0100, Peter Zijlstra wrote: > On Wed, Mar 24, 2021 at 11:42:24AM +, Mel Gorman wrote: > > On Wed, Mar 24, 2021 at 11:54:24AM +0100, Peter Zijlstra wrote: > > > On Wed, Mar 24, 2021 at 10:37:43AM +0100, Peter Zijlstra wrote: > > > > Should we perhaps take out

Re: [PATCH v2] sched: Warn on long periods of pending need_resched

2021-03-24 Thread Peter Zijlstra
On Wed, Mar 24, 2021 at 11:42:24AM +, Mel Gorman wrote: > On Wed, Mar 24, 2021 at 11:54:24AM +0100, Peter Zijlstra wrote: > > On Wed, Mar 24, 2021 at 10:37:43AM +0100, Peter Zijlstra wrote: > > > Should we perhaps take out all SCHED_DEBUG sysctls and move them to > > > /debug/sched/ ? (along wi

Re: [PATCH v2] sched: Warn on long periods of pending need_resched

2021-03-24 Thread Mel Gorman
On Wed, Mar 24, 2021 at 11:54:24AM +0100, Peter Zijlstra wrote: > On Wed, Mar 24, 2021 at 10:37:43AM +0100, Peter Zijlstra wrote: > > Should we perhaps take out all SCHED_DEBUG sysctls and move them to > > /debug/sched/ ? (along with the existing > > /debug/sched_{debug,features,preemp} > > files)

Re: [PATCH v2] sched: Warn on long periods of pending need_resched

2021-03-24 Thread Mel Gorman
On Mon, Mar 22, 2021 at 08:57:06PM -0700, Josh Don wrote: > From: Paul Turner > > CPU scheduler marks need_resched flag to signal a schedule() on a > particular CPU. But, schedule() may not happen immediately in cases > where the current task is executing in the kernel mode (no > preemption state

Re: [PATCH v2] sched: Warn on long periods of pending need_resched

2021-03-24 Thread Peter Zijlstra
On Wed, Mar 24, 2021 at 11:54:24AM +0100, Peter Zijlstra wrote: > On Wed, Mar 24, 2021 at 10:37:43AM +0100, Peter Zijlstra wrote: > > Should we perhaps take out all SCHED_DEBUG sysctls and move them to > > /debug/sched/ ? (along with the existing > > /debug/sched_{debug,features,preemp} > > files)

Re: [PATCH v2] sched: Warn on long periods of pending need_resched

2021-03-24 Thread Peter Zijlstra
On Wed, Mar 24, 2021 at 10:37:43AM +0100, Peter Zijlstra wrote: > Should we perhaps take out all SCHED_DEBUG sysctls and move them to > /debug/sched/ ? (along with the existing /debug/sched_{debug,features,preemp} > files) > > Having all that in sysctl and documented gives them far too much sheen

Re: [PATCH v2] sched: Warn on long periods of pending need_resched

2021-03-24 Thread Peter Zijlstra
On Mon, Mar 22, 2021 at 08:57:06PM -0700, Josh Don wrote: > From: Paul Turner > > CPU scheduler marks need_resched flag to signal a schedule() on a > particular CPU. But, schedule() may not happen immediately in cases > where the current task is executing in the kernel mode (no > preemption state