Re: [PATCH v2] soc: imx: Add generic i.MX8 SoC driver

2019-02-27 Thread Leonard Crestez
On Wed, 2019-02-27 at 08:41 +, Abel Vesa wrote: > On 19-02-26 13:34:52, Leonard Crestez wrote: > > On Tue, 2019-02-26 at 10:53 +, Abel Vesa wrote: > > > Add generic i.MX8 SoC driver along with the i.MX8MQ SoC specific code. > > > For now, only i.MX8MQ revision B1 is supported. For any other

Re: [PATCH v2] soc: imx: Add generic i.MX8 SoC driver

2019-02-27 Thread Abel Vesa
On 19-02-26 13:34:52, Leonard Crestez wrote: > On Tue, 2019-02-26 at 10:53 +, Abel Vesa wrote: > > Add generic i.MX8 SoC driver along with the i.MX8MQ SoC specific code. > > For now, only i.MX8MQ revision B1 is supported. For any other, i.MX8MQ > > revision it will print 'unknown'. > > > > +

Re: [PATCH v2] soc: imx: Add generic i.MX8 SoC driver

2019-02-26 Thread Fabio Estevam
On Tue, Feb 26, 2019 at 10:37 AM Fabio Estevam wrote: > > On Tue, Feb 26, 2019 at 7:53 AM Abel Vesa wrote: > > > + magic = readl_relaxed(ocotp_base + IMX8MQ_SW_INFO_B1); > > + if (magic == IMX8MQ_SW_MAGIC_B1) > > + rev = REV_B1; > > Don't you mean rev == REV_B1; ? Ops,

Re: [PATCH v2] soc: imx: Add generic i.MX8 SoC driver

2019-02-26 Thread Fabio Estevam
On Tue, Feb 26, 2019 at 7:53 AM Abel Vesa wrote: > + magic = readl_relaxed(ocotp_base + IMX8MQ_SW_INFO_B1); > + if (magic == IMX8MQ_SW_MAGIC_B1) > + rev = REV_B1; Don't you mean rev == REV_B1; ?

Re: [PATCH v2] soc: imx: Add generic i.MX8 SoC driver

2019-02-26 Thread Leonard Crestez
On Tue, 2019-02-26 at 10:53 +, Abel Vesa wrote: > Add generic i.MX8 SoC driver along with the i.MX8MQ SoC specific code. > For now, only i.MX8MQ revision B1 is supported. For any other, i.MX8MQ > revision it will print 'unknown'. > > + np = of_find_compatible_node(NULL, NULL, "fsl,imx8mq-o

Re: [PATCH v2] soc: imx: Add generic i.MX8 SoC driver

2019-02-26 Thread Chris Spencer
On Tue, 26 Feb 2019 at 10:53, Abel Vesa wrote: > Add generic i.MX8 SoC driver along with the i.MX8MQ SoC specific code. > For now, only i.MX8MQ revision B1 is supported. For any other, i.MX8MQ > revision it will print 'unknown'. > > Signed-off-by: Abel Vesa Tested on i.MX8MQ-EVK. No idea what i.