Re: [PATCH v2] staging: media: meson: vdec: declare u32 as const and static const

2021-04-12 Thread Neil Armstrong
On 12/04/2021 14:45, Mitali Borkar wrote: > On Mon, Apr 12, 2021 at 11:17:22AM +0200, Hans Verkuil wrote: >> On 10/04/2021 21:59, Mitali Borkar wrote: >>> Declared 32 bit unsigned int as static constant inside a function and >>> replaced u32[] {x,y} as canvas1, canvas2 in codec_mpeg12.c >>> This in

Re: [PATCH v2] staging: media: meson: vdec: declare u32 as const and static const

2021-04-12 Thread Mitali Borkar
On Mon, Apr 12, 2021 at 11:17:22AM +0200, Hans Verkuil wrote: > On 10/04/2021 21:59, Mitali Borkar wrote: > > Declared 32 bit unsigned int as static constant inside a function and > > replaced u32[] {x,y} as canvas1, canvas2 in codec_mpeg12.c > > This indicates the value of canvas indexes will rema

Re: [PATCH v2] staging: media: meson: vdec: declare u32 as const and static const

2021-04-12 Thread Hans Verkuil
On 10/04/2021 21:59, Mitali Borkar wrote: > Declared 32 bit unsigned int as static constant inside a function and > replaced u32[] {x,y} as canvas1, canvas2 in codec_mpeg12.c > This indicates the value of canvas indexes will remain constant throughout > execution. > Replaced u32 reg_base and u32 r