Re: [PATCH v2] tomoyo: Don't check open/getattr permission on sockets.

2019-08-22 Thread Eric Biggers
On Thu, Aug 22, 2019 at 04:42:26PM +0900, Tetsuo Handa wrote: > Eric Biggers wrote: > > On Thu, Aug 22, 2019 at 03:55:31PM +0900, Tetsuo Handa wrote: > > > > Also, isn't the same bug in other places too?: > > > > > > > > - tomoyo_path_chmod() > > > > - tomoyo_path_chown() > > > >

Re: [PATCH v2] tomoyo: Don't check open/getattr permission on sockets.

2019-08-22 Thread Tetsuo Handa
Eric Biggers wrote: > On Thu, Aug 22, 2019 at 03:55:31PM +0900, Tetsuo Handa wrote: > > > Also, isn't the same bug in other places too?: > > > > > > - tomoyo_path_chmod() > > > - tomoyo_path_chown() > > > - smack_inode_getsecurity() > > > - smack_inode_setsecurity() > > > > What's the bug

Re: [PATCH v2] tomoyo: Don't check open/getattr permission on sockets.

2019-08-22 Thread Eric Biggers
On Thu, Aug 22, 2019 at 03:55:31PM +0900, Tetsuo Handa wrote: > Eric Biggers wrote: > > What happened to this patch? > > I have to learn how to manage a git tree for sending > pull requests, but I can't find time to try. > > > > > Also, isn't the same bug in other places too?: > > > > - tom

Re: [PATCH v2] tomoyo: Don't check open/getattr permission on sockets.

2019-08-21 Thread Tetsuo Handa
Eric Biggers wrote: > What happened to this patch? I have to learn how to manage a git tree for sending pull requests, but I can't find time to try. > > Also, isn't the same bug in other places too?: > > - tomoyo_path_chmod() > - tomoyo_path_chown() > - smack_inode_getsecurity

Re: [PATCH v2] tomoyo: Don't check open/getattr permission on sockets.

2019-08-21 Thread Eric Biggers
Hi Tetsuo, On Sat, Jun 22, 2019 at 01:45:30PM +0900, Tetsuo Handa wrote: > On 2019/06/19 5:49, Al Viro wrote: > > On Sun, Jun 16, 2019 at 03:49:00PM +0900, Tetsuo Handa wrote: > >> Hello, Al. > >> > >> Q1: Do you agree that we should fix TOMOYO side rather than SOCKET_I()->sk > >> management.