Re: [PATCH v2] tpm: enable PPI for TPM 2.0

2015-04-22 Thread Jarkko Sakkinen
On Tue, Apr 21, 2015 at 01:33:38PM -0600, Jason Gunthorpe wrote: > On Tue, Apr 21, 2015 at 09:30:55PM +0300, Jarkko Sakkinen wrote: > > Enabled PPI interface to the character device sysfs directory accessible > > both for 1.x and 2.0 devices. > > > > The ppi group is moved from the platform device

Re: [PATCH v2] tpm: enable PPI for TPM 2.0

2015-04-21 Thread Jarkko Sakkinen
On Tue, Apr 21, 2015 at 01:33:38PM -0600, Jason Gunthorpe wrote: > On Tue, Apr 21, 2015 at 09:30:55PM +0300, Jarkko Sakkinen wrote: > > Enabled PPI interface to the character device sysfs directory accessible > > both for 1.x and 2.0 devices. > > > > The ppi group is moved from the platform device

Re: [PATCH v2] tpm: enable PPI for TPM 2.0

2015-04-21 Thread Jarkko Sakkinen
On Tue, Apr 21, 2015 at 11:58:33AM -0700, Guenter Roeck wrote: > On Tue, Apr 21, 2015 at 09:30:55PM +0300, Jarkko Sakkinen wrote: > > Enabled PPI interface to the character device sysfs directory accessible > > both for 1.x and 2.0 devices. > > > > The ppi group is moved from the platform device d

Re: [PATCH v2] tpm: enable PPI for TPM 2.0

2015-04-21 Thread Jarkko Sakkinen
On Tue, Apr 21, 2015 at 09:52:14PM +0200, Greg Kroah-Hartman wrote: > On Tue, Apr 21, 2015 at 09:30:55PM +0300, Jarkko Sakkinen wrote: > > -#define to_tpm_chip(n) container_of(n, struct tpm_chip, vendor) > > +#define to_tpm_chip(n) container_of(dev, struct tpm_chip, dev) > > That doesn't look corr

Re: [PATCH v2] tpm: enable PPI for TPM 2.0

2015-04-21 Thread Greg Kroah-Hartman
On Tue, Apr 21, 2015 at 09:30:55PM +0300, Jarkko Sakkinen wrote: > -#define to_tpm_chip(n) container_of(n, struct tpm_chip, vendor) > +#define to_tpm_chip(n) container_of(dev, struct tpm_chip, dev) That doesn't look correct to me... thanks, greg k-h -- To unsubscribe from this list: send the lin

Re: [PATCH v2] tpm: enable PPI for TPM 2.0

2015-04-21 Thread Jason Gunthorpe
On Tue, Apr 21, 2015 at 09:30:55PM +0300, Jarkko Sakkinen wrote: > Enabled PPI interface to the character device sysfs directory accessible > both for 1.x and 2.0 devices. > > The ppi group is moved from the platform device directory to the > character device directory. In order to retain backward

Re: [PATCH v2] tpm: enable PPI for TPM 2.0

2015-04-21 Thread Guenter Roeck
On Tue, Apr 21, 2015 at 09:30:55PM +0300, Jarkko Sakkinen wrote: > Enabled PPI interface to the character device sysfs directory accessible > both for 1.x and 2.0 devices. > > The ppi group is moved from the platform device directory to the > character device directory. In order to retain backward