Re: [PATCH v2] virtio_balloon: Convert "vballon" kthread into a workqueue

2014-11-14 Thread Petr Mladek
On Fri 2014-11-14 08:19:15, Tejun Heo wrote: > Hello, Michael, Petr. > > On Wed, Nov 12, 2014 at 03:32:04PM +0200, Michael S. Tsirkin wrote: > > > + /* The workqueue servicing the balloon. */ > > > + struct workqueue_struct *wq; > > > + struct work_struct wq_work; > > > > We could use system_free

Re: [PATCH v2] virtio_balloon: Convert "vballon" kthread into a workqueue

2014-11-14 Thread Tejun Heo
Hello, Michael, Petr. On Wed, Nov 12, 2014 at 03:32:04PM +0200, Michael S. Tsirkin wrote: > > + /* The workqueue servicing the balloon. */ > > + struct workqueue_struct *wq; > > + struct work_struct wq_work; > > We could use system_freezable_wq instead. > I do agree a dedicated wq is better

Re: [PATCH v2] virtio_balloon: Convert "vballon" kthread into a workqueue

2014-11-12 Thread Jeff Epler
Trivial typo "vballon" should be "vballoon" in subject (and in changelog, leak_ballon should be leak_balloon) Jeff -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordo

Re: [PATCH v2] virtio_balloon: Convert "vballon" kthread into a workqueue

2014-11-12 Thread Michael S. Tsirkin
On Wed, Nov 12, 2014 at 02:02:48PM +0100, Petr Mladek wrote: > Workqueues have clean and rich API for all basic operations. The code is > usually > easier and better readable. It can be easily tuned for the given purpose. > > In many cases, it allows to avoid an extra kernel thread. It helps to s