Re: [PATCH v2 0/5] KVM: x86: improve reexecute_instruction

2012-12-23 Thread Gleb Natapov
On Fri, Dec 14, 2012 at 11:05:46PM -0200, Marcelo Tosatti wrote: > On Fri, Dec 14, 2012 at 12:50:09PM +0800, Xiao Guangrong wrote: > > >>> program a timer interrupt and #GP? > > >> > > >> Could you please explain the detail? > > > > > > Before the instruction which writes continuously to the

Re: [PATCH v2 0/5] KVM: x86: improve reexecute_instruction

2012-12-23 Thread Gleb Natapov
On Fri, Dec 14, 2012 at 11:05:46PM -0200, Marcelo Tosatti wrote: On Fri, Dec 14, 2012 at 12:50:09PM +0800, Xiao Guangrong wrote: program a timer interrupt and #GP? Could you please explain the detail? Before the instruction which writes continuously to the pagetable, arm say

Re: [PATCH v2 0/5] KVM: x86: improve reexecute_instruction

2012-12-14 Thread Marcelo Tosatti
On Fri, Dec 14, 2012 at 12:50:09PM +0800, Xiao Guangrong wrote: > >>> program a timer interrupt and #GP? > >> > >> Could you please explain the detail? > > > > Before the instruction which writes continuously to the pagetable, arm > > say lapic timer. #GP on the interrupt handler and test with

Re: [PATCH v2 0/5] KVM: x86: improve reexecute_instruction

2012-12-14 Thread Marcelo Tosatti
On Fri, Dec 14, 2012 at 12:50:09PM +0800, Xiao Guangrong wrote: program a timer interrupt and #GP? Could you please explain the detail? Before the instruction which writes continuously to the pagetable, arm say lapic timer. #GP on the interrupt handler and test with failure.

Re: [PATCH v2 0/5] KVM: x86: improve reexecute_instruction

2012-12-13 Thread Xiao Guangrong
On 12/14/2012 06:54 AM, Marcelo Tosatti wrote: > On Thu, Dec 13, 2012 at 04:05:55AM +0800, Xiao Guangrong wrote: >> On 12/12/2012 07:36 AM, Marcelo Tosatti wrote: >>> On Mon, Dec 10, 2012 at 05:11:35PM +0800, Xiao Guangrong wrote: Changelog: There are some changes from Marcelo and Gleb's

Re: [PATCH v2 0/5] KVM: x86: improve reexecute_instruction

2012-12-13 Thread Marcelo Tosatti
On Thu, Dec 13, 2012 at 04:05:55AM +0800, Xiao Guangrong wrote: > On 12/12/2012 07:36 AM, Marcelo Tosatti wrote: > > On Mon, Dec 10, 2012 at 05:11:35PM +0800, Xiao Guangrong wrote: > >> Changelog: > >> There are some changes from Marcelo and Gleb's review, thank you all! > >> - access

Re: [PATCH v2 0/5] KVM: x86: improve reexecute_instruction

2012-12-13 Thread Marcelo Tosatti
On Thu, Dec 13, 2012 at 04:05:55AM +0800, Xiao Guangrong wrote: On 12/12/2012 07:36 AM, Marcelo Tosatti wrote: On Mon, Dec 10, 2012 at 05:11:35PM +0800, Xiao Guangrong wrote: Changelog: There are some changes from Marcelo and Gleb's review, thank you all! - access indirect_shadow_pages in

Re: [PATCH v2 0/5] KVM: x86: improve reexecute_instruction

2012-12-13 Thread Xiao Guangrong
On 12/14/2012 06:54 AM, Marcelo Tosatti wrote: On Thu, Dec 13, 2012 at 04:05:55AM +0800, Xiao Guangrong wrote: On 12/12/2012 07:36 AM, Marcelo Tosatti wrote: On Mon, Dec 10, 2012 at 05:11:35PM +0800, Xiao Guangrong wrote: Changelog: There are some changes from Marcelo and Gleb's review, thank

Re: [PATCH v2 0/5] KVM: x86: improve reexecute_instruction

2012-12-12 Thread Xiao Guangrong
On 12/12/2012 07:36 AM, Marcelo Tosatti wrote: > On Mon, Dec 10, 2012 at 05:11:35PM +0800, Xiao Guangrong wrote: >> Changelog: >> There are some changes from Marcelo and Gleb's review, thank you all! >> - access indirect_shadow_pages in the protection of mmu-lock >> - fix the issue when

Re: [PATCH v2 0/5] KVM: x86: improve reexecute_instruction

2012-12-12 Thread Xiao Guangrong
On 12/12/2012 07:36 AM, Marcelo Tosatti wrote: On Mon, Dec 10, 2012 at 05:11:35PM +0800, Xiao Guangrong wrote: Changelog: There are some changes from Marcelo and Gleb's review, thank you all! - access indirect_shadow_pages in the protection of mmu-lock - fix the issue when unhandleable

Re: [PATCH v2 0/5] KVM: x86: improve reexecute_instruction

2012-12-11 Thread Marcelo Tosatti
On Mon, Dec 10, 2012 at 05:11:35PM +0800, Xiao Guangrong wrote: > Changelog: > There are some changes from Marcelo and Gleb's review, thank you all! > - access indirect_shadow_pages in the protection of mmu-lock > - fix the issue when unhandleable instruction access on large page > - add a new

Re: [PATCH v2 0/5] KVM: x86: improve reexecute_instruction

2012-12-11 Thread Marcelo Tosatti
On Mon, Dec 10, 2012 at 05:11:35PM +0800, Xiao Guangrong wrote: Changelog: There are some changes from Marcelo and Gleb's review, thank you all! - access indirect_shadow_pages in the protection of mmu-lock - fix the issue when unhandleable instruction access on large page - add a new test