Re: [PATCH v2 0/9] uprobes/x86: preparations to fix the reprel jmp/call handling.

2014-04-04 Thread Jim Keniston
On Fri, 2014-04-04 at 21:32 +0200, Oleg Nesterov wrote: > On 04/04, Oleg Nesterov wrote: > > > > Now let me send the draft RFC patch which fixes the "call" handling... > > Damn. apparently I can't understand lib/insn.c... > > Please see the draft below. Lets ignore 32bit tasks, lets ignore jmp's,

Re: [PATCH v2 0/9] uprobes/x86: preparations to fix the reprel jmp/call handling.

2014-04-04 Thread Oleg Nesterov
On 04/04, Oleg Nesterov wrote: > > +static int ttt_post_xol_op(struct arch_uprobe *auprobe, struct pt_regs *regs) > +{ > + regs->sp += 8; > + if (ttt_emulate_op(auprobe, regs)) > + return 0; > + return -ERESTART; > +} forgets to update ->ip before ttt_emulate_op(). Or we ca

Re: [PATCH v2 0/9] uprobes/x86: preparations to fix the reprel jmp/call handling.

2014-04-04 Thread Oleg Nesterov
On 04/04, Oleg Nesterov wrote: > > Now let me send the draft RFC patch which fixes the "call" handling... Damn. apparently I can't understand lib/insn.c... Please see the draft below. Lets ignore 32bit tasks, lets ignore jmp's, please ignore how the (pseudo) code written, I'll change it anyway.