Re: [PATCH v2 00/16] Common Dell SMBIOS API

2016-02-09 Thread Michał Kępień
> > > Most of my concerns were addressed by later patches in the series. I have > > > pushed > > > a version of this 1/7 fixed per lkp (linux/io.h) and 7/16 with a > > > corrected body > > > as I sent in reply to that patch. This is on my tree as the dell-smbios > > > branch. Thanks! > > > >

Re: [PATCH v2 00/16] Common Dell SMBIOS API

2016-02-08 Thread Darren Hart
On Mon, Feb 08, 2016 at 10:04:32PM +0100, Pali Rohár wrote: > On Monday 08 February 2016 21:46:46 Darren Hart wrote: > > Pali, are you happy enough with this to add your reviewed-by? > > There was dicussion about dell-smbios API which you probably missed in > tons of other emails. It has subject:

Re: [PATCH v2 00/16] Common Dell SMBIOS API

2016-02-08 Thread Pali Rohár
On Monday 08 February 2016 21:46:46 Darren Hart wrote: > Pali, are you happy enough with this to add your reviewed-by? There was dicussion about dell-smbios API which you probably missed in tons of other emails. It has subject: "[PATCH 01/14] dell-laptop: extract SMBIOS-related code to a separate

Re: [PATCH v2 00/16] Common Dell SMBIOS API

2016-02-08 Thread Darren Hart
On Mon, Feb 08, 2016 at 11:29:20AM -0800, Greg Kroah-Hartman wrote: > On Mon, Feb 08, 2016 at 11:20:14AM -0800, Darren Hart wrote: > > On Fri, Jan 22, 2016 at 03:48:51PM +0100, Pali Rohár wrote: > > > On Friday 22 January 2016 15:27:12 Michał Kępień wrote: > > > > Note: > > > > > > > > In this

Re: [PATCH v2 00/16] Common Dell SMBIOS API

2016-02-08 Thread Darren Hart
On Mon, Feb 08, 2016 at 08:30:07PM +0100, Lukas Wunner wrote: > Hi, > > On Mon, Feb 08, 2016 at 11:20:14AM -0800, Darren Hart wrote: > > My only major concern is module load order dependencies. Inter-module > > dependencies are frowned upon with good reason, the kernel load ordering is > > non-det

Re: [PATCH v2 00/16] Common Dell SMBIOS API

2016-02-08 Thread Lukas Wunner
Hi, On Mon, Feb 08, 2016 at 11:20:14AM -0800, Darren Hart wrote: > My only major concern is module load order dependencies. Inter-module > dependencies are frowned upon with good reason, the kernel load ordering is > non-deterministic and it's possible, for example, for dell-laptop to fail to > fi

Re: [PATCH v2 00/16] Common Dell SMBIOS API

2016-02-08 Thread Greg Kroah-Hartman
On Mon, Feb 08, 2016 at 11:20:14AM -0800, Darren Hart wrote: > On Fri, Jan 22, 2016 at 03:48:51PM +0100, Pali Rohár wrote: > > On Friday 22 January 2016 15:27:12 Michał Kępień wrote: > > > Note: > > > > > > In this series (both v1 and v2) I tried to stick to the overall > > > concept used

Re: [PATCH v2 00/16] Common Dell SMBIOS API

2016-02-08 Thread Darren Hart
On Fri, Jan 22, 2016 at 03:48:51PM +0100, Pali Rohár wrote: > On Friday 22 January 2016 15:27:12 Michał Kępień wrote: > > Note: > > > > In this series (both v1 and v2) I tried to stick to the overall > > concept used in dell-laptop, but in the v1 thread me and Pali also > > briefly dis

Re: [PATCH v2 00/16] Common Dell SMBIOS API

2016-02-07 Thread Darren Hart
On Fri, Jan 22, 2016 at 03:48:51PM +0100, Pali Rohár wrote: > On Friday 22 January 2016 15:27:12 Michał Kępień wrote: > > Note: > > > > In this series (both v1 and v2) I tried to stick to the overall > > concept used in dell-laptop, but in the v1 thread me and Pali also > > briefly dis

Re: [PATCH v2 00/16] Common Dell SMBIOS API

2016-01-22 Thread Pali Rohár
On Friday 22 January 2016 15:27:12 Michał Kępień wrote: > Note: > > In this series (both v1 and v2) I tried to stick to the overall > concept used in dell-laptop, but in the v1 thread me and Pali also > briefly discussed his alternative ideas [1][2] as to what this API > could look