Re: [PATCH v2 01/15] net: proc entry showing inodes on sockfs and their types

2012-08-11 Thread Masatake YAMATO
> > Sorry, you cannot do this. > > You are adding a new lock and insert into a global list for > pretty much every socket created, that will destroy performance. I think there are no serious performance penalty in generally use. Most frequently used types of sockets like tcp, udp, and unix are n

Re: [PATCH v2 01/15] net: proc entry showing inodes on sockfs and their types

2012-08-11 Thread David Miller
I also want to mention that I absolutely do not consider better lsof support important at all. So if you want to add this, it had to be exactly zero overhead and it must not break anything that exists already. Your patch set violates this on both counts. -- To unsubscribe from this list: send th

Re: [PATCH v2 01/15] net: proc entry showing inodes on sockfs and their types

2012-08-11 Thread David Miller
Sorry, you cannot do this. You are adding a new lock and insert into a global list for pretty much every socket created, that will destroy performance. You also cannnot add new fields to socket listing procfs files, it will break existing application which depend upon the existing exact layout o