Re: [PATCH v2 03/19] scsi: libsas: Introduce a _gfp() variant of event notifiers

2021-01-12 Thread Sebastian A. Siewior
On 2021-01-12 15:45:12 [+], Christoph Hellwig wrote: > What is the problem with simply adding a gfp_t argument to the existing > calls? The end result of this series looks fine, but the way we get > there looks extremely cumbersome. Maybe I don't understand you fully but if you want to avoid

Re: [PATCH v2 03/19] scsi: libsas: Introduce a _gfp() variant of event notifiers

2021-01-12 Thread Christoph Hellwig
On Tue, Jan 12, 2021 at 12:06:31PM +0100, Ahmed S. Darwish wrote: > sas_alloc_event() uses in_interrupt() to decide which allocation should > be used. > > The usage of in_interrupt() in drivers is phased out and Linus clearly > requested that code which changes behaviour depending on context shoul