Re: [PATCH v2 03/20] mm, hugetlb: fix subpool accounting handling

2013-08-27 Thread Joonsoo Kim
On Mon, Aug 26, 2013 at 06:31:35PM +0530, Aneesh Kumar K.V wrote: > Joonsoo Kim writes: > > > On Thu, Aug 22, 2013 at 12:38:12PM +0530, Aneesh Kumar K.V wrote: > >> Joonsoo Kim writes: > >> > >> > Hello, Aneesh. > >> > > >> > First of all, thank you for review! > >> > > >> > On Wed, Aug 21, 201

Re: [PATCH v2 03/20] mm, hugetlb: fix subpool accounting handling

2013-08-26 Thread Aneesh Kumar K.V
Joonsoo Kim writes: > On Thu, Aug 22, 2013 at 12:38:12PM +0530, Aneesh Kumar K.V wrote: >> Joonsoo Kim writes: >> >> > Hello, Aneesh. >> > >> > First of all, thank you for review! >> > >> > On Wed, Aug 21, 2013 at 02:58:20PM +0530, Aneesh Kumar K.V wrote: >> >> Joonsoo Kim writes: >> >> >> >>

Re: [PATCH v2 03/20] mm, hugetlb: fix subpool accounting handling

2013-08-22 Thread Joonsoo Kim
On Thu, Aug 22, 2013 at 12:38:12PM +0530, Aneesh Kumar K.V wrote: > Joonsoo Kim writes: > > > Hello, Aneesh. > > > > First of all, thank you for review! > > > > On Wed, Aug 21, 2013 at 02:58:20PM +0530, Aneesh Kumar K.V wrote: > >> Joonsoo Kim writes: > >> > >> > If we alloc hugepage with avoid

Re: [PATCH v2 03/20] mm, hugetlb: fix subpool accounting handling

2013-08-22 Thread Aneesh Kumar K.V
Joonsoo Kim writes: > Hello, Aneesh. > > First of all, thank you for review! > > On Wed, Aug 21, 2013 at 02:58:20PM +0530, Aneesh Kumar K.V wrote: >> Joonsoo Kim writes: >> >> > If we alloc hugepage with avoid_reserve, we don't dequeue reserved one. >> > So, we should check subpool counter when

Re: [PATCH v2 03/20] mm, hugetlb: fix subpool accounting handling

2013-08-21 Thread Joonsoo Kim
Hello, Aneesh. First of all, thank you for review! On Wed, Aug 21, 2013 at 02:58:20PM +0530, Aneesh Kumar K.V wrote: > Joonsoo Kim writes: > > > If we alloc hugepage with avoid_reserve, we don't dequeue reserved one. > > So, we should check subpool counter when avoid_reserve. > > This patch imp

Re: [PATCH v2 03/20] mm, hugetlb: fix subpool accounting handling

2013-08-21 Thread Aneesh Kumar K.V
Joonsoo Kim writes: > If we alloc hugepage with avoid_reserve, we don't dequeue reserved one. > So, we should check subpool counter when avoid_reserve. > This patch implement it. Can you explain this better ? ie, if we don't have a reservation in the area chg != 0. So why look at avoid_reserve.