Re: [PATCH v2 04/14] soundwire: Add MIPI DisCo property helpers

2017-11-27 Thread Charles Keepax
On Mon, Nov 27, 2017 at 02:48:50PM +0530, Vinod Koul wrote: > On Mon, Nov 27, 2017 at 07:59:40AM +, Charles Keepax wrote: > > > > > Apologies for the long and slightly vague comment, but I guess my > > > > question is do you have a thought on how drivers should know when > > > > it is safe to

Re: [PATCH v2 04/14] soundwire: Add MIPI DisCo property helpers

2017-11-27 Thread Vinod Koul
On Mon, Nov 27, 2017 at 07:59:40AM +, Charles Keepax wrote: > > > Apologies for the long and slightly vague comment, but I guess my > > > question is do you have a thought on how drivers should know when > > > it is safe to communicate with a SoundWire device? > > > > IMO it is safe to commun

Re: [PATCH v2 04/14] soundwire: Add MIPI DisCo property helpers

2017-11-27 Thread Charles Keepax
On Fri, Nov 24, 2017 at 09:34:49PM +0530, Sanyog Kale wrote: > On Thu, Nov 23, 2017 at 02:38:12PM +, Charles Keepax wrote: > > On Fri, Nov 10, 2017 at 05:19:06PM +0530, Vinod Koul wrote: > > > > MIPI Discovery And Configuration (DisCo) Specification for SoundWire > > > specifies properties to

Re: [PATCH v2 04/14] soundwire: Add MIPI DisCo property helpers

2017-11-24 Thread Sanyog Kale
On Thu, Nov 23, 2017 at 02:38:12PM +, Charles Keepax wrote: > On Fri, Nov 10, 2017 at 05:19:06PM +0530, Vinod Koul wrote: > > MIPI Discovery And Configuration (DisCo) Specification for SoundWire > > specifies properties to be implemented for SoundWire Masters and > > Slaves. The DisCo spec doe

Re: [PATCH v2 04/14] soundwire: Add MIPI DisCo property helpers

2017-11-23 Thread Charles Keepax
On Fri, Nov 10, 2017 at 05:19:06PM +0530, Vinod Koul wrote: > MIPI Discovery And Configuration (DisCo) Specification for SoundWire > specifies properties to be implemented for SoundWire Masters and > Slaves. The DisCo spec doesn't mandate these properties. However, > SDW bus cannot work without kno

Re: [PATCH v2 04/14] soundwire: Add MIPI DisCo property helpers

2017-11-16 Thread Vinod Koul
On Thu, Nov 16, 2017 at 04:05:34PM +, Srinivas Kandagatla wrote: > Few Minor comments!! All are helpful :) > >+/** > >+ * enum sdw_clk_stop_mode: Clock Stop modes > >+ * > >+ * @SDW_CLK_STOP_MODE_0: Slave can continue operation seamlessly on clock > >+ * restart > >+ * @SDW_CLK_STOP_MODE_1: S

Re: [PATCH v2 04/14] soundwire: Add MIPI DisCo property helpers

2017-11-16 Thread Srinivas Kandagatla
Few Minor comments!! On 10/11/17 11:49, Vinod Koul wrote: Signed-off-by: Sanyog Kale Signed-off-by: Vinod Koul --- drivers/soundwire/Makefile | 2 +- drivers/soundwire/bus.c| 8 + drivers/soundwire/bus_type.c | 18 ++ drivers/soundwire/mipi_disco.c | 422 ++