Re: [PATCH v2 08/12] ARM: dts: imx6dl-pico: fix board compatibles

2020-10-05 Thread Fabio Estevam
Hi Marco, On Fri, Oct 2, 2020 at 5:41 AM Marco Felsch wrote: > Question is what was the author's intention? @Fabio do you have any > comments here? Krzysztof's patch looks good: Reviewed-by: Fabio Estevam Thanks

Re: [PATCH v2 08/12] ARM: dts: imx6dl-pico: fix board compatibles

2020-10-02 Thread Krzysztof Kozlowski
On Fri, Oct 02, 2020 at 10:41:19AM +0200, Marco Felsch wrote: > Hi, > > sorry for jumping in. > > On 20-10-02 10:20, Krzysztof Kozlowski wrote: > > On Fri, Oct 02, 2020 at 09:41:28AM +0200, Ahmad Fatoum wrote: > > > Hello, > > > > > > On 10/1/20 12:37 PM, Krzysztof Kozlowski wrote: > > > >> The

Re: [PATCH v2 08/12] ARM: dts: imx6dl-pico: fix board compatibles

2020-10-02 Thread Marco Felsch
Hi, sorry for jumping in. On 20-10-02 10:20, Krzysztof Kozlowski wrote: > On Fri, Oct 02, 2020 at 09:41:28AM +0200, Ahmad Fatoum wrote: > > Hello, > > > > On 10/1/20 12:37 PM, Krzysztof Kozlowski wrote: > > >> The existing binding doesn't cover these boards then and needs to be > > >> extended,

Re: [PATCH v2 08/12] ARM: dts: imx6dl-pico: fix board compatibles

2020-10-02 Thread Ahmad Fatoum
Hello, On 10/2/20 10:20 AM, Krzysztof Kozlowski wrote: > On Fri, Oct 02, 2020 at 09:41:28AM +0200, Ahmad Fatoum wrote: >> Hello, >> >> On 10/1/20 12:37 PM, Krzysztof Kozlowski wrote: The existing binding doesn't cover these boards then and needs to be extended, no? How about following pa

Re: [PATCH v2 08/12] ARM: dts: imx6dl-pico: fix board compatibles

2020-10-02 Thread Krzysztof Kozlowski
On Fri, Oct 02, 2020 at 09:41:28AM +0200, Ahmad Fatoum wrote: > Hello, > > On 10/1/20 12:37 PM, Krzysztof Kozlowski wrote: > >> The existing binding doesn't cover these boards then and needs to be > >> extended, no? How about following patch? > > > > What do you mean it doesn't cover? It was adde

Re: [PATCH v2 08/12] ARM: dts: imx6dl-pico: fix board compatibles

2020-10-02 Thread Ahmad Fatoum
Hello, On 10/1/20 12:37 PM, Krzysztof Kozlowski wrote: >> The existing binding doesn't cover these boards then and needs to be >> extended, no? How about following patch? > > What do you mean it doesn't cover? It was added exactly to handle them: > + - technexion,imx6q-pico-dwarf #

Re: [PATCH v2 08/12] ARM: dts: imx6dl-pico: fix board compatibles

2020-10-01 Thread Krzysztof Kozlowski
On Thu, Oct 01, 2020 at 12:19:08PM +0200, Ahmad Fatoum wrote: > Hi, > > On 10/1/20 9:32 AM, Krzysztof Kozlowski wrote: > > On Thu, Oct 01, 2020 at 09:22:03AM +0200, Ahmad Fatoum wrote: > >>> diff --git a/arch/arm/boot/dts/imx6dl-pico-hobbit.dts > >>> b/arch/arm/boot/dts/imx6dl-pico-hobbit.dts > >

Re: [PATCH v2 08/12] ARM: dts: imx6dl-pico: fix board compatibles

2020-10-01 Thread Ahmad Fatoum
Hi, On 10/1/20 9:32 AM, Krzysztof Kozlowski wrote: > On Thu, Oct 01, 2020 at 09:22:03AM +0200, Ahmad Fatoum wrote: >>> diff --git a/arch/arm/boot/dts/imx6dl-pico-hobbit.dts >>> b/arch/arm/boot/dts/imx6dl-pico-hobbit.dts >>> index d7403c5c4337..08fedcbcc91b 100644 >>> --- a/arch/arm/boot/dts/imx6d

Re: [PATCH v2 08/12] ARM: dts: imx6dl-pico: fix board compatibles

2020-10-01 Thread Krzysztof Kozlowski
On Thu, Oct 01, 2020 at 09:22:03AM +0200, Ahmad Fatoum wrote: > Hello Krzysztof, > > On 9/30/20 9:01 PM, Krzysztof Kozlowski wrote: > > There are four flavors of TechNexion PICO-IMX6 boards. They have their > > own DTSes, even though in Dwarf, Nymph and Pi are exactly the same. > > They also have

Re: [PATCH v2 08/12] ARM: dts: imx6dl-pico: fix board compatibles

2020-10-01 Thread Ahmad Fatoum
Hello Krzysztof, On 9/30/20 9:01 PM, Krzysztof Kozlowski wrote: > There are four flavors of TechNexion PICO-IMX6 boards. They have their > own DTSes, even though in Dwarf, Nymph and Pi are exactly the same. > They also have their own bindings so adjust the compatibles to match the > bindings. >