RE: [PATCH v2 1/1] irqchip: imx-gpcv2: Simplify the implementation

2015-08-28 Thread Thomas Gleixner
On Fri, 28 Aug 2015, Shenwei Wang wrote: > > So once again. As you said before nothing is going to use the case where > > source > > == NULL, can we please get rid of it? > > It will be used to allocate the memory for the predefined values of > interrupts for each power Domain. Can we keep it? I

RE: [PATCH v2 1/1] irqchip: imx-gpcv2: Simplify the implementation

2015-08-28 Thread Shenwei Wang
g > Yongcai-B20788 > Subject: Re: [PATCH v2 1/1] irqchip: imx-gpcv2: Simplify the implementation > > On Wed, 26 Aug 2015, Shenwei Wang wrote: > > u32 imx_gpcv2_get_wakeup_source(u32 **sources) { > > - if (!imx_gpcv2_instance) > > + struct gpcv2_irqchip_da

Re: [PATCH v2 1/1] irqchip: imx-gpcv2: Simplify the implementation

2015-08-28 Thread Thomas Gleixner
On Wed, 26 Aug 2015, Shenwei Wang wrote: > u32 imx_gpcv2_get_wakeup_source(u32 **sources) > { > - if (!imx_gpcv2_instance) > + struct gpcv2_irqchip_data *cd; > + void __iomem *reg; > + int i; > + > + cd = imx_gpcv2_instance; > + if (!cd) > return 0; > > +