Re: [PATCH v2 1/2] ASoC: codec: Inno codec driver for RK3036 SoC

2015-11-06 Thread Mark Brown
On Fri, Nov 06, 2015 at 04:15:37PM +0800, Shunqian Zheng wrote: > On 2015年11月06日 00:13, Mark Brown wrote: > >On Thu, Nov 05, 2015 at 05:53:13PM +0800, Shunqian Zheng wrote: > >This looks like a simple boolean control rather than an enum - it looks > >like it's just turning antipop on and off. > I

Re: [PATCH v2 1/2] ASoC: codec: Inno codec driver for RK3036 SoC

2015-11-06 Thread Shunqian Zheng
Mark, On 2015年11月06日 00:13, Mark Brown wrote: On Thu, Nov 05, 2015 at 05:53:13PM +0800, Shunqian Zheng wrote: This is basically all good, a few very minor comments below but nothing that should take any time to fix. +static const char *rk3036_codec_antipop_text[] = {"none", "work"}; +static c

Re: [PATCH v2 1/2] ASoC: codec: Inno codec driver for RK3036 SoC

2015-11-06 Thread Shunqian Zheng
LABBE, On 2015年11月05日 20:47, LABBE Corentin wrote: On Thu, Nov 05, 2015 at 05:53:13PM +0800, Shunqian Zheng wrote: From: ZhengShunQian RK3036 SoC integrated with an Inno audio codec. This driver implements the functions of it. There is not need a special machine driver, since the simple-car

Re: [PATCH v2 1/2] ASoC: codec: Inno codec driver for RK3036 SoC

2015-11-05 Thread Mark Brown
On Thu, Nov 05, 2015 at 05:53:13PM +0800, Shunqian Zheng wrote: This is basically all good, a few very minor comments below but nothing that should take any time to fix. > +static const char *rk3036_codec_antipop_text[] = {"none", "work"}; > +static const unsigned int rk3036_codec_antipop_values[

Re: [PATCH v2 1/2] ASoC: codec: Inno codec driver for RK3036 SoC

2015-11-05 Thread LABBE Corentin
On Thu, Nov 05, 2015 at 05:53:13PM +0800, Shunqian Zheng wrote: > From: ZhengShunQian > > RK3036 SoC integrated with an Inno audio codec. > This driver implements the functions of it. > > There is not need a special machine driver, since the > simple-card machine driver works perfect in this cas