Re: [PATCH v2 1/2] NTB: Migrate PCI Constants to Cannonical PCI Header

2018-05-23 Thread Doug Meyer
Dear Logan, Thank you for the comment. My gmail filters got me and I never saw Bjorn's comments on pci_ids.h. I'll start work on v3 when I get another window of time at work. Blessings, Doug On Wed, May 23, 2018 at 1:26 PM, Logan Gunthorpe wrote: > > > On 23/05/18 02:18 PM, dme...@gigaio.com w

Re: [PATCH v2 1/2] NTB: Migrate PCI Constants to Cannonical PCI Header

2018-05-23 Thread Logan Gunthorpe
On 23/05/18 02:18 PM, dme...@gigaio.com wrote: > +#define PCI_DEVICE_ID_MICROSEMI_PFX24XG3 0x8531 I think Bjorn asked not to add the device IDs to the pci_ids.h and to just use the raw IDs in quirks.h. switchtec.c already uses the raw values. Besides that, it looks good to me. Reviewed-by: