Re: [PATCH v2 1/2] leds: Add support for Palmas LEDs

2013-03-12 Thread Ian Lartey
On 12/03/13 18:57, Bryan Wu wrote: On Thu, Feb 28, 2013 at 7:21 AM, Ian Lartey wrote: The Palmas familly of chips has LED support. This is not always muxed to output pins so depending on the setting of the mux this driver will create the appropriate LED class devices. Signed-off-by: Graeme Gre

Re: [PATCH v2 1/2] leds: Add support for Palmas LEDs

2013-03-12 Thread Bryan Wu
On Tue, Mar 12, 2013 at 12:10 PM, Mark Brown wrote: > On Tue, Mar 12, 2013 at 11:57:50AM -0700, Bryan Wu wrote: >> On Thu, Feb 28, 2013 at 7:21 AM, Ian Lartey wrote: > >> > + spinlock_t value_lock; > >> I think you don't need this spinlock to protect the value, the mutex is >> enough. > >

Re: [PATCH v2 1/2] leds: Add support for Palmas LEDs

2013-03-12 Thread Mark Brown
On Tue, Mar 12, 2013 at 11:57:50AM -0700, Bryan Wu wrote: > On Thu, Feb 28, 2013 at 7:21 AM, Ian Lartey wrote: > > + spinlock_t value_lock; > I think you don't need this spinlock to protect the value, the mutex is > enough. You need to use a spinlock because values can be set from hard I

Re: [PATCH v2 1/2] leds: Add support for Palmas LEDs

2013-03-12 Thread Bryan Wu
On Thu, Feb 28, 2013 at 7:21 AM, Ian Lartey wrote: > The Palmas familly of chips has LED support. This is not always muxed > to output pins so depending on the setting of the mux this driver > will create the appropriate LED class devices. > > Signed-off-by: Graeme Gregory > Signed-off-by: Ian La

Re: [PATCH v2 1/2] leds: Add support for Palmas LEDs

2013-02-28 Thread Ian Lartey
On 28/02/13 18:36, Stephen Warren wrote: On 02/28/2013 08:21 AM, Ian Lartey wrote: The Palmas familly of chips has LED support. This is not always muxed to output pins so depending on the setting of the mux this driver will create the appropriate LED class devices. +static struct of_device_id

Re: [PATCH v2 1/2] leds: Add support for Palmas LEDs

2013-02-28 Thread Stephen Warren
On 02/28/2013 08:21 AM, Ian Lartey wrote: > The Palmas familly of chips has LED support. This is not always muxed > to output pins so depending on the setting of the mux this driver > will create the appropriate LED class devices. > +static struct of_device_id of_palmas_match_tbl[] = { > + { .