Re: [PATCH v2 1/3] ext4: Add alignment check for DAX mount

2016-05-04 Thread Toshi Kani
On Tue, 2016-05-03 at 15:41 +, Kani, Toshimitsu wrote: > On Tue, 2016-05-03 at 08:43 -0600, Ross Zwisler wrote: > > On Tue, May 03, 2016 at 11:00:21AM +0200, Jan Kara wrote: > > > On Tue 03-05-16 01:44:10, Christoph Hellwig wrote: > > > > > > > > Please come up with a version that doesn't requ

Re: [PATCH v2 1/3] ext4: Add alignment check for DAX mount

2016-05-03 Thread Toshi Kani
On Tue, 2016-05-03 at 08:43 -0600, Ross Zwisler wrote: > On Tue, May 03, 2016 at 11:00:21AM +0200, Jan Kara wrote: > > > > On Tue 03-05-16 01:44:10, Christoph Hellwig wrote: > > > > > > Please come up with a version that doesn't require tons of > > > boilerplate code in every file system. > > > >

Re: [PATCH v2 1/3] ext4: Add alignment check for DAX mount

2016-05-03 Thread Ross Zwisler
On Tue, May 03, 2016 at 11:00:21AM +0200, Jan Kara wrote: > On Tue 03-05-16 01:44:10, Christoph Hellwig wrote: > > Please come up with a version that doesn't require tons of boilerplate > > code in every file system. > > Well, I was thinking about some helper as well but we could save ~4 lines > w

Re: [PATCH v2 1/3] ext4: Add alignment check for DAX mount

2016-05-03 Thread Jan Kara
On Tue 03-05-16 01:44:10, Christoph Hellwig wrote: > Please come up with a version that doesn't require tons of boilerplate > code in every file system. Well, I was thinking about some helper as well but we could save ~4 lines with that and that didn't seem significant to me. Most of the lines is

Re: [PATCH v2 1/3] ext4: Add alignment check for DAX mount

2016-05-03 Thread Christoph Hellwig
Please come up with a version that doesn't require tons of boilerplate code in every file system.

Re: [PATCH v2 1/3] ext4: Add alignment check for DAX mount

2016-05-03 Thread Jan Kara
On Mon 02-05-16 12:42:56, Toshi Kani wrote: > When a partition is not aligned by 4KB, mount -o dax succeeds, > but any read/write access to the filesystem fails, except for > metadata update. > > Call bdev_direct_access to check the alignment when -o dax is > specified. > > Reported-by: Micah Par