Re: [PATCH v2 1/3] iio: magnetometer: Add support for MEMSIC MMC35240 sensor

2015-06-30 Thread Daniel Baluta
On Mon, Jun 29, 2015 at 10:17 PM, Hartmut Knaack wrote: > Daniel Baluta schrieb am 29.06.2015 um 09:52: >> On Mon, Jun 29, 2015 at 2:07 AM, Hartmut Knaack wrote: >>> Daniel Baluta schrieb am 24.04.2015 um 17:58: Minimal implementation for MMC35240 3-axis magnetometer sensor. It provides

Re: [PATCH v2 1/3] iio: magnetometer: Add support for MEMSIC MMC35240 sensor

2015-06-29 Thread Hartmut Knaack
Daniel Baluta schrieb am 29.06.2015 um 09:52: > On Mon, Jun 29, 2015 at 2:07 AM, Hartmut Knaack wrote: >> Daniel Baluta schrieb am 24.04.2015 um 17:58: >>> Minimal implementation for MMC35240 3-axis magnetometer >>> sensor. It provides processed readings and possiblity to change >>> the sampling f

Re: [PATCH v2 1/3] iio: magnetometer: Add support for MEMSIC MMC35240 sensor

2015-06-29 Thread Daniel Baluta
On Mon, Jun 29, 2015 at 2:07 AM, Hartmut Knaack wrote: > Daniel Baluta schrieb am 24.04.2015 um 17:58: >> Minimal implementation for MMC35240 3-axis magnetometer >> sensor. It provides processed readings and possiblity to change >> the sampling frequency. >> > > Hi Daniel, > please find a few issu

Re: [PATCH v2 1/3] iio: magnetometer: Add support for MEMSIC MMC35240 sensor

2015-06-28 Thread Hartmut Knaack
Daniel Baluta schrieb am 24.04.2015 um 17:58: > Minimal implementation for MMC35240 3-axis magnetometer > sensor. It provides processed readings and possiblity to change > the sampling frequency. > Hi Daniel, please find a few issues inline, which you could address in a next rework patch set. I w

Re: [PATCH v2 1/3] iio: magnetometer: Add support for MEMSIC MMC35240 sensor

2015-05-08 Thread Jonathan Cameron
On 24/04/15 11:58, Daniel Baluta wrote: > Minimal implementation for MMC35240 3-axis magnetometer > sensor. It provides processed readings and possiblity to change > the sampling frequency. > > Signed-off-by: Daniel Baluta Applied with a couple of statics and a const that were suggested by compil