Re: [PATCH v2 1/3] mfd: tps6586x: add version detection

2013-12-02 Thread Mark Brown
On Sun, Dec 01, 2013 at 04:59:13PM +0100, Stefan Agner wrote: > +int tps6586x_get_version(struct device *dev) > +{ > + struct tps6586x *tps6586x = dev_get_drvdata(dev); > + > + return tps6586x->version; > +} > +EXPORT_SYMBOL_GPL(tps6586x_get_version); May as well make this a static inline

Re: [PATCH v2 1/3] mfd: tps6586x: add version detection

2013-12-02 Thread Thierry Reding
On Sun, Dec 01, 2013 at 04:59:13PM +0100, Stefan Agner wrote: > Use the VERSIONCRC to determine the exact device version. According to > the datasheet this register can be used as device identifier. The > identification is needed since some tps6586x regulators use a different > voltage table. > >