Re: [PATCH v2 1/3] net/usb/r815x: replace USB buffer from stack to DMA-able

2013-07-29 Thread David Miller
From: Oliver Neukum Date: Mon, 29 Jul 2013 07:20:24 +0200 > On Sat, 2013-07-27 at 20:21 -0700, David Miller wrote: >> From: Hayes Wang >> Date: Thu, 25 Jul 2013 15:59:02 +0800 >> >> > Some USB buffers use stack which may not be DMA-able. >> > Use the buffers from kmalloc to replace those one. >

Re: [PATCH v2 1/3] net/usb/r815x: replace USB buffer from stack to DMA-able

2013-07-28 Thread Oliver Neukum
On Sat, 2013-07-27 at 20:21 -0700, David Miller wrote: > From: Hayes Wang > Date: Thu, 25 Jul 2013 15:59:02 +0800 > > > Some USB buffers use stack which may not be DMA-able. > > Use the buffers from kmalloc to replace those one. > > > > Signed-off-by: Hayes Wang > > I don't think it's reasonab

Re: [PATCH v2 1/3] net/usb/r815x: replace USB buffer from stack to DMA-able

2013-07-27 Thread David Miller
From: Hayes Wang Date: Thu, 25 Jul 2013 15:59:02 +0800 > Some USB buffers use stack which may not be DMA-able. > Use the buffers from kmalloc to replace those one. > > Signed-off-by: Hayes Wang I don't think it's reasonable to kmalloc() a small integer every time you want to use a USB message