Re: [PATCH v2 1/3] usb: notify hcd when USB device suspend or resume

2015-05-13 Thread Alan Stern
On Wed, 13 May 2015, Lu, Baolu wrote: > From software point of view, the extra time it takes to ask for cache > operation can be measured in xhci_device_suspend(). I can measure > the data later when I complete my tasks in hand. If that data is ignorable > comparing to the suspend time, we can si

Re: [PATCH v2 1/3] usb: notify hcd when USB device suspend or resume

2015-05-12 Thread Lu, Baolu
On 05/12/2015 11:54 PM, Alan Stern wrote: On Tue, 12 May 2015, Lu, Baolu wrote: I'm sorry that I confused you. FSC is a different thing from what this patch series does. I know that. The patch series, in its current form, is fine. Now I'm trying to understand what you originally wanted to

Re: [PATCH v2 1/3] usb: notify hcd when USB device suspend or resume

2015-05-12 Thread Alan Stern
On Tue, 12 May 2015, Lu, Baolu wrote: > I'm sorry that I confused you. > > FSC is a different thing from what this patch series does. I know that. The patch series, in its current form, is fine. Now I'm trying to understand what you originally wanted to do. > > Let's see if I understand it co

Re: [PATCH v2 1/3] usb: notify hcd when USB device suspend or resume

2015-05-11 Thread Lu, Baolu
On 05/11/2015 10:25 PM, Alan Stern wrote: On Sat, 9 May 2015, Lu, Baolu wrote: If FSC is supported, the cached Slot, Endpoint, Stream, or other Context information are also saved. Hence, when FSC is supported, software does not have to issue Stop Endpoint Command to push public and private

Re: [PATCH v2 1/3] usb: notify hcd when USB device suspend or resume

2015-05-11 Thread Alan Stern
On Sat, 9 May 2015, Lu, Baolu wrote: > >> If FSC is supported, the cached Slot, Endpoint, Stream, or other > >> Context information are also saved. > >> > >> Hence, when FSC is supported, software does not have to issue Stop > >> Endpoint Command to push public and private endpoint state into > >

Re: [PATCH v2 1/3] usb: notify hcd when USB device suspend or resume

2015-05-08 Thread Lu, Baolu
On 05/08/2015 10:21 PM, Alan Stern wrote: On Fri, 8 May 2015, Lu, Baolu wrote: On 05/07/2015 10:34 PM, Alan Stern wrote: On Thu, 7 May 2015, Lu, Baolu wrote: + void(*device_suspend)(struct usb_hcd *, struct usb_device *udev, + pm_message_t msg); + void

Re: [PATCH v2 1/3] usb: notify hcd when USB device suspend or resume

2015-05-08 Thread Alan Stern
On Fri, 8 May 2015, Lu, Baolu wrote: > On 05/07/2015 10:34 PM, Alan Stern wrote: > > On Thu, 7 May 2015, Lu, Baolu wrote: > > > +void(*device_suspend)(struct usb_hcd *, struct usb_device > *udev, > +pm_message_t msg); > +void(*de

Re: [PATCH v2 1/3] usb: notify hcd when USB device suspend or resume

2015-05-08 Thread Lu, Baolu
On 05/06/2015 10:35 PM, Alan Stern wrote: diff --git a/include/linux/usb/hcd.h b/include/linux/usb/hcd.h >index 68b1e83..621d9b7 100644 >--- a/include/linux/usb/hcd.h >+++ b/include/linux/usb/hcd.h >@@ -383,7 +383,13 @@ struct hc_driver { >int (*find_raw_port_number)(struct usb_hcd *, i

Re: [PATCH v2 1/3] usb: notify hcd when USB device suspend or resume

2015-05-07 Thread Lu, Baolu
On 05/07/2015 10:34 PM, Alan Stern wrote: On Thu, 7 May 2015, Lu, Baolu wrote: + void(*device_suspend)(struct usb_hcd *, struct usb_device *udev, + pm_message_t msg); + void(*device_resume)(struct usb_hcd *, struct usb_device *udev, +

Re: [PATCH v2 1/3] usb: notify hcd when USB device suspend or resume

2015-05-07 Thread Alan Stern
On Thu, 7 May 2015, Lu, Baolu wrote: > >> + void(*device_suspend)(struct usb_hcd *, struct usb_device *udev, > >> + pm_message_t msg); > >> + void(*device_resume)(struct usb_hcd *, struct usb_device *udev, > >> + pm_message_t msg); > >> }; > > Your cal

Re: [PATCH v2 1/3] usb: notify hcd when USB device suspend or resume

2015-05-06 Thread Lu, Baolu
On 05/06/2015 10:35 PM, Alan Stern wrote: On Wed, 6 May 2015, Lu Baolu wrote: This patch adds two new entries in hc_driver. With these new entries, USB core can notify host driver when a USB device is about to suspend or just resumed. The xHCI spec is designed to allow an xHC implementation

Re: [PATCH v2 1/3] usb: notify hcd when USB device suspend or resume

2015-05-06 Thread Alan Stern
On Wed, 6 May 2015, Lu Baolu wrote: > This patch adds two new entries in hc_driver. With these new entries, > USB core can notify host driver when a USB device is about to suspend > or just resumed. > > The xHCI spec is designed to allow an xHC implementation to cache the > endpoint state. Cachin