Re: [PATCH v2 1/3] watchdog: Add Meson GXBB Watchdog Driver

2016-06-07 Thread Guenter Roeck
On Mon, Jun 06, 2016 at 09:48:41AM +0200, Neil Armstrong wrote: > Hi Guenter, > [ ... ] > >> + * > >> + * Copyright (c) 2016 BayLibre, SAS. > >> + * Author: Neil Armstrong > >> + * > > Nitpick, but you don't really need the copyright and author lines twice. > > Sorry, but I was asked to use this

Re: [PATCH v2 1/3] watchdog: Add Meson GXBB Watchdog Driver

2016-06-06 Thread Neil Armstrong
Hi Guenter, On 06/04/2016 07:57 PM, Guenter Roeck wrote: > On 06/03/2016 01:36 AM, Neil Armstrong wrote: [...] >> +++ b/drivers/watchdog/meson_gxbb_wdt.c >> @@ -0,0 +1,268 @@ >> +/* >> + * This file is provided under a dual BSD/GPLv2 license. When using or >> + * redistributing this file, you may

Re: [PATCH v2 1/3] watchdog: Add Meson GXBB Watchdog Driver

2016-06-04 Thread Guenter Roeck
On 06/03/2016 01:36 AM, Neil Armstrong wrote: Add watchdog specific driver for Amlogic Meson GXBB SoC. Signed-off-by: Neil Armstrong --- drivers/watchdog/Kconfig | 10 ++ drivers/watchdog/Makefile | 1 + drivers/watchdog/meson_gxbb_wdt.c | 268 +++