Re: [PATCH v2 1/3] x86: add support for Huawei WMI hotkeys.

2018-11-05 Thread Takashi Iwai
On Sat, 03 Nov 2018 00:10:18 +0100, wrote: > > On Fri, 2018-11-02 at 20:20 +0200, Andy Shevchenko wrote: > > > +#include > > > +#include > > > +#include > > > +#include > > > > Please, keep in order. > > What order do I have to follow? Does this look right? > module.h > init.h > apci.h > wm

Re: [PATCH v2 1/3] x86: add support for Huawei WMI hotkeys.

2018-11-02 Thread ayman . bagabas
On Fri, 2018-11-02 at 20:20 +0200, Andy Shevchenko wrote: > On Fri, Nov 2, 2018 at 6:11 AM Ayman Bagabas > wrote: > > > > This driver adds support for missing hotkeys on some Huawei > > laptops. > > Currently, only Huawei Matebook X Pro is supported. The driver > > recognizes the following keys:

Re: [PATCH v2 1/3] x86: add support for Huawei WMI hotkeys.

2018-11-02 Thread Andy Shevchenko
On Fri, Nov 2, 2018 at 6:11 AM Ayman Bagabas wrote: > > This driver adds support for missing hotkeys on some Huawei laptops. > Currently, only Huawei Matebook X Pro is supported. The driver > recognizes the following keys: brightness keys, micmute, wlan, and > Huawei special key. The brightness ke